From d157ea0d3213953aaa7687b0441cecb8c42b44b7 Mon Sep 17 00:00:00 2001
From: Arlen Johnson <arlen@sphericalcowgroup.com>
Date: Fri, 9 Sep 2022 17:42:47 -0400
Subject: [PATCH] Avoid unnecessary animation, particularly on page load
 (CO-2330)

---
 app/templates/MatchgridSettings/fields.inc | 8 ++++----
 app/templates/Permissions/fields.inc       | 2 +-
 app/templates/RuleAttributes/fields.inc    | 7 ++-----
 app/templates/SystemsOfRecord/fields.inc   | 4 ++--
 4 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/app/templates/MatchgridSettings/fields.inc b/app/templates/MatchgridSettings/fields.inc
index 456c7d631..48436670f 100644
--- a/app/templates/MatchgridSettings/fields.inc
+++ b/app/templates/MatchgridSettings/fields.inc
@@ -36,11 +36,11 @@ use \App\Lib\Enum\ReferenceIdEnum;
     var method = document.getElementById('referenceid-method').value;
 
     if(method == '<?= ReferenceIdEnum::Sequence ?>') {
-      $("#referenceid-prefix").closest('li').show('fade');
-      $("#referenceid-start").closest('li').show('fade');
+      $("#referenceid-prefix").closest('li').show();
+      $("#referenceid-start").closest('li').show();
     } else {
-      $("#referenceid-prefix").closest('li').hide('fade');
-      $("#referenceid-start").closest('li').hide('fade');
+      $("#referenceid-prefix").closest('li').hide();
+      $("#referenceid-start").closest('li').hide();
     }
   }
   
diff --git a/app/templates/Permissions/fields.inc b/app/templates/Permissions/fields.inc
index 711ecd9ca..04876de61 100644
--- a/app/templates/Permissions/fields.inc
+++ b/app/templates/Permissions/fields.inc
@@ -40,7 +40,7 @@ use \App\Lib\Enum\PermissionEnum;
       // Blank out Matchgrid ID
       document.getElementById('matchgrid-id').selectedIndex = 0;
     } else {
-      $("#matchgrid-id").closest('li').show('fade');
+      $("#matchgrid-id").closest('li').show();
     }
   }
   
diff --git a/app/templates/RuleAttributes/fields.inc b/app/templates/RuleAttributes/fields.inc
index 9e0fac9e4..310dd9010 100644
--- a/app/templates/RuleAttributes/fields.inc
+++ b/app/templates/RuleAttributes/fields.inc
@@ -39,12 +39,9 @@ use \App\Lib\Enum\SearchTypeEnum;
     if(req) {
       // If the RuleAttribute is Required, we can't Match Empty Values since the
       // attribute isn't permitted to be empty
-      
-      document.getElementById('match-empty').closest('li').hidden = true;
-      // XXX we want .show('fade') but jquery apparently not set up?
-      // or maybe not... instant update actually looks better
+      $("#match-empty").closest('li').hide();
     } else {
-      document.getElementById('match-empty').closest('li').hidden = false;
+      $("#match-empty").closest('li').show();
     }
   }
   
diff --git a/app/templates/SystemsOfRecord/fields.inc b/app/templates/SystemsOfRecord/fields.inc
index a41f62b5e..56e2684b2 100644
--- a/app/templates/SystemsOfRecord/fields.inc
+++ b/app/templates/SystemsOfRecord/fields.inc
@@ -36,9 +36,9 @@ use \App\Lib\Enum\ResolutionModeEnum;
     var method = document.getElementById('resolution-mode').value;
 
     if(method == '<?= ResolutionModeEnum::External ?>') {
-      $("#notification-email").closest('li').show('fade');
+      $("#notification-email").closest('li').show();
     } else {
-      $("#notification-email").closest('li').hide('fade');
+      $("#notification-email").closest('li').hide();
     }
   }