Fix Group Membership breadcrumb and subnav title for Person Canvas

COmanage · Apr 15, 2026 · de934df · de934df
1 parent e036aa8
commit de934df
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/app/resources/locales/en_US/menu.po b/app/resources/locales/en_US/menu.po
@@ -90,6 +90,9 @@ msgstr "All Features"
 msgid "co.groups"
 msgstr "Groups"
 
+msgid "co.groups.memberships"
+msgstr "Group Memberships"
+
 msgid "co.operations"
 msgstr "Operations"
 

diff --git a/app/resources/locales/en_US/operation.po b/app/resources/locales/en_US/operation.po
@@ -404,6 +404,3 @@ msgstr "View Petition {0}"
 
 msgid "view.ExternalIdentityRoles.a"
 msgstr "View Role {0}"
-
-msgid "person.memberships"
-msgstr "My Memberships"
diff --git a/app/src/Controller/GroupMembersController.php b/app/src/Controller/GroupMembersController.php
@@ -76,10 +76,10 @@ public function beforeRender(EventInterface $event) {
 
     // If we're in a Person context (index filtered by ?person_id=...), override the page title.
     if (
-      in_array($this->getRequest()->getParam('action'), ['index'], true)
+      $this->getRequest()->getParam('action') === 'index'
       && $this->getRequest()->getQuery('person_id') !== null
     ) {
-      $this->set('vv_title', __d('operation', 'person.memberships'));
+      $this->set('vv_title', __d('menu', 'co.groups.memberships'));
 
       // Ensure the breadcrumb leaf is plain text (no extra title-links).
       $this->set('vv_bc_title_links', []);

diff --git a/app/templates/GroupMembers/columns.inc b/app/templates/GroupMembers/columns.inc
@@ -153,8 +153,14 @@ if ($this->request->getQuery('group_id') !== null) {
   ];
 
   $subnav = 'people';
-  $localTitle = __d('controller','Groups', 99);
-
+  // If we're in a Person context (index filtered by ?person_id=...), do not override the subnav title.
+  if (
+    $this->getRequest()->getParam('action') === 'index'
+    && empty($this->getRequest()->getQuery('person_id'))
+  ) {
+    $localTitle = __d('controller','Groups', 99);
+  }
+
   // Do not show the normal add link here
   $suppressAddLink = true;
 ?>