From f32493b74acdacf490a5731fb674d8f1c51a569b Mon Sep 17 00:00:00 2001
From: Arlen Johnson <arlen@sphericalcowgroup.com>
Date: Wed, 24 Sep 2025 14:36:29 -0400
Subject: [PATCH] Remove 'edit only' blocking statements. (CFM-218)

---
 .../ApiConnector/templates/ApiSources/fields.inc             | 5 -----
 app/plugins/CoreApi/templates/MatchCallbacks/fields.inc      | 5 -----
 .../CoreAssigner/templates/FormatAssigners/fields.inc        | 5 -----
 app/plugins/CoreAssigner/templates/SqlAssigners/fields.inc   | 5 -----
 .../CoreEnroller/templates/ApprovalCollectors/fields.inc     | 5 -----
 .../CoreEnroller/templates/AttributeCollectors/fields.inc    | 5 -----
 .../templates/BasicAttributeCollectors/fields.inc            | 5 -----
 app/plugins/CoreEnroller/templates/EmailVerifiers/fields.inc | 5 -----
 .../CoreEnroller/templates/IdentifierCollectors/fields.inc   | 5 -----
 .../CoreEnroller/templates/InvitationAccepters/fields.inc    | 5 -----
 app/plugins/CoreServer/templates/HttpServers/fields.inc      | 5 -----
 app/plugins/CoreServer/templates/Oauth2Servers/fields.inc    | 5 -----
 app/plugins/CoreServer/templates/SmtpServers/fields.inc      | 5 -----
 app/plugins/CoreServer/templates/SqlServers/fields.inc       | 5 -----
 .../EnvSource/templates/EnvSourceCollectors/fields.inc       | 5 -----
 app/plugins/EnvSource/templates/EnvSources/fields.inc        | 5 -----
 .../OrcidSource/templates/OrcidSourceCollectors/fields.inc   | 5 -----
 app/plugins/OrcidSource/templates/OrcidSources/fields.inc    | 5 -----
 18 files changed, 90 deletions(-)

diff --git a/app/availableplugins/ApiConnector/templates/ApiSources/fields.inc b/app/availableplugins/ApiConnector/templates/ApiSources/fields.inc
index aafecdcdc..25798a722 100644
--- a/app/availableplugins/ApiConnector/templates/ApiSources/fields.inc
+++ b/app/availableplugins/ApiConnector/templates/ApiSources/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only
-if($vv_action !== 'edit') {
-  return;
-}
-
 // XXX https://todos.internet2.edu/browse/CFM-465 send type - this should be 'information' (not a warning)
 $banners = [
   __d('information', 'plugin.config.none')
diff --git a/app/plugins/CoreApi/templates/MatchCallbacks/fields.inc b/app/plugins/CoreApi/templates/MatchCallbacks/fields.inc
index 1b3e8743d..03a0d342a 100644
--- a/app/plugins/CoreApi/templates/MatchCallbacks/fields.inc
+++ b/app/plugins/CoreApi/templates/MatchCallbacks/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 if(!empty($vv_api_endpoint)) {
   // XXX https://todos.internet2.edu/browse/CFM-465 send type - this should be 'information' (not a warning)
   $banners = [
diff --git a/app/plugins/CoreAssigner/templates/FormatAssigners/fields.inc b/app/plugins/CoreAssigner/templates/FormatAssigners/fields.inc
index 482436417..2fb2e5bfa 100644
--- a/app/plugins/CoreAssigner/templates/FormatAssigners/fields.inc
+++ b/app/plugins/CoreAssigner/templates/FormatAssigners/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'format',
   'collision_mode',
diff --git a/app/plugins/CoreAssigner/templates/SqlAssigners/fields.inc b/app/plugins/CoreAssigner/templates/SqlAssigners/fields.inc
index 2b2b3cbce..d31414b75 100644
--- a/app/plugins/CoreAssigner/templates/SqlAssigners/fields.inc
+++ b/app/plugins/CoreAssigner/templates/SqlAssigners/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'server_id',
   'source_table',
diff --git a/app/plugins/CoreEnroller/templates/ApprovalCollectors/fields.inc b/app/plugins/CoreEnroller/templates/ApprovalCollectors/fields.inc
index bcab2bc7b..d70c14837 100644
--- a/app/plugins/CoreEnroller/templates/ApprovalCollectors/fields.inc
+++ b/app/plugins/CoreEnroller/templates/ApprovalCollectors/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'require_comment',
   'denial_message_template_id',
diff --git a/app/plugins/CoreEnroller/templates/AttributeCollectors/fields.inc b/app/plugins/CoreEnroller/templates/AttributeCollectors/fields.inc
index 48add49a8..9c9f1c2ef 100644
--- a/app/plugins/CoreEnroller/templates/AttributeCollectors/fields.inc
+++ b/app/plugins/CoreEnroller/templates/AttributeCollectors/fields.inc
@@ -27,11 +27,6 @@
 
 declare(strict_types = 1);
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'enable_person_find',
 ];
diff --git a/app/plugins/CoreEnroller/templates/BasicAttributeCollectors/fields.inc b/app/plugins/CoreEnroller/templates/BasicAttributeCollectors/fields.inc
index 04520baf4..f1c33e0f7 100644
--- a/app/plugins/CoreEnroller/templates/BasicAttributeCollectors/fields.inc
+++ b/app/plugins/CoreEnroller/templates/BasicAttributeCollectors/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}  
-  
 $fields = [
   'name_type_id',
   'email_address_type_id',
diff --git a/app/plugins/CoreEnroller/templates/EmailVerifiers/fields.inc b/app/plugins/CoreEnroller/templates/EmailVerifiers/fields.inc
index 46ed063d5..15a4bb8ec 100644
--- a/app/plugins/CoreEnroller/templates/EmailVerifiers/fields.inc
+++ b/app/plugins/CoreEnroller/templates/EmailVerifiers/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 // Used for placeholders
 $defaultValues = array_combine(
   array_values($defaults),
diff --git a/app/plugins/CoreEnroller/templates/IdentifierCollectors/fields.inc b/app/plugins/CoreEnroller/templates/IdentifierCollectors/fields.inc
index a2c0482ec..f719a2fd7 100644
--- a/app/plugins/CoreEnroller/templates/IdentifierCollectors/fields.inc
+++ b/app/plugins/CoreEnroller/templates/IdentifierCollectors/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'type_id'
 ];
diff --git a/app/plugins/CoreEnroller/templates/InvitationAccepters/fields.inc b/app/plugins/CoreEnroller/templates/InvitationAccepters/fields.inc
index d254122f5..61ee21bbb 100644
--- a/app/plugins/CoreEnroller/templates/InvitationAccepters/fields.inc
+++ b/app/plugins/CoreEnroller/templates/InvitationAccepters/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'invitation_validity' => [
     'default'   => 1440
diff --git a/app/plugins/CoreServer/templates/HttpServers/fields.inc b/app/plugins/CoreServer/templates/HttpServers/fields.inc
index fc105cf8c..f242894ec 100644
--- a/app/plugins/CoreServer/templates/HttpServers/fields.inc
+++ b/app/plugins/CoreServer/templates/HttpServers/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}  
-
 $fields = [
   'url',
   'username',
diff --git a/app/plugins/CoreServer/templates/Oauth2Servers/fields.inc b/app/plugins/CoreServer/templates/Oauth2Servers/fields.inc
index ed4416964..329ab0d5b 100644
--- a/app/plugins/CoreServer/templates/Oauth2Servers/fields.inc
+++ b/app/plugins/CoreServer/templates/Oauth2Servers/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 // Render the Redirect URI
 $fields = [
   'redirect_uri' => [
diff --git a/app/plugins/CoreServer/templates/SmtpServers/fields.inc b/app/plugins/CoreServer/templates/SmtpServers/fields.inc
index dc1d57f69..5cd2706f0 100644
--- a/app/plugins/CoreServer/templates/SmtpServers/fields.inc
+++ b/app/plugins/CoreServer/templates/SmtpServers/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'hostname',
   'port' => [
diff --git a/app/plugins/CoreServer/templates/SqlServers/fields.inc b/app/plugins/CoreServer/templates/SqlServers/fields.inc
index c510cefcd..0108053c0 100644
--- a/app/plugins/CoreServer/templates/SqlServers/fields.inc
+++ b/app/plugins/CoreServer/templates/SqlServers/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does currently not support read-only, and add is not used
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'type',
   'hostname',
diff --git a/app/plugins/EnvSource/templates/EnvSourceCollectors/fields.inc b/app/plugins/EnvSource/templates/EnvSourceCollectors/fields.inc
index 1c89eefba..a6d5ae141 100644
--- a/app/plugins/EnvSource/templates/EnvSourceCollectors/fields.inc
+++ b/app/plugins/EnvSource/templates/EnvSourceCollectors/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}  
-
 $fields = [
   'external_identity_source_id' => [
     'fieldLabel' => __d('env_source', 'controller.EnvSources', [1])
diff --git a/app/plugins/EnvSource/templates/EnvSources/fields.inc b/app/plugins/EnvSource/templates/EnvSources/fields.inc
index c15613e99..73c73b89e 100644
--- a/app/plugins/EnvSource/templates/EnvSources/fields.inc
+++ b/app/plugins/EnvSource/templates/EnvSources/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view does not currently support read-only
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   // 'duplicate_mode',
   'sp_mode',
diff --git a/app/plugins/OrcidSource/templates/OrcidSourceCollectors/fields.inc b/app/plugins/OrcidSource/templates/OrcidSourceCollectors/fields.inc
index 6475d5b07..1bd5230e4 100644
--- a/app/plugins/OrcidSource/templates/OrcidSourceCollectors/fields.inc
+++ b/app/plugins/OrcidSource/templates/OrcidSourceCollectors/fields.inc
@@ -25,11 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-// This view only supports edit
-if($vv_action !== 'edit') {
-  return;
-}
-
 $fields = [
   'external_identity_source_id' => [
     'fieldLabel' => __d('orcid_source', 'controller.OrcidSources', [1])
diff --git a/app/plugins/OrcidSource/templates/OrcidSources/fields.inc b/app/plugins/OrcidSource/templates/OrcidSources/fields.inc
index 98acdcab4..c10e0733d 100644
--- a/app/plugins/OrcidSource/templates/OrcidSources/fields.inc
+++ b/app/plugins/OrcidSource/templates/OrcidSources/fields.inc
@@ -27,11 +27,6 @@
 
 use OrcidSource\Lib\Enum\OrcidSourceScopeEnum;
 
-// This view does not currently support read-only
-if($vv_action !== 'edit') {
-  return;
-}
-
 $vv_inherited_scopes = OrcidSourceScopeEnum::DEFAULT_SCOPE;
 if (filter_var($vv_obj->scope_inherit, FILTER_VALIDATE_BOOLEAN)) {
   $vv_inherited_scopes = $vv_obj->server?->oauth2_server?->scope ?? OrcidSourceScopeEnum::DEFAULT_SCOPE;