diff --git a/build.xml b/build.xml index 5c7a8cb8..5090f0f5 100644 --- a/build.xml +++ b/build.xml @@ -742,8 +742,12 @@ Parameter 'i' is the file to be checked; no assumption is made about its location so this must contain a full path. - Parameter 's' is the checking stylesheet to use; assumed to be + Parameter 's' is the primary checking stylesheet to use; assumed to be present in the build.dir. + + A fixed set of additional checking stylesheets are included in every run; + the one passed as a parameter should only contain rules specific to the + calling context. --> @@ -761,6 +765,11 @@ + + + + + diff --git a/build/check.xsl b/build/check.xsl index 755d18fd..7677c190 100644 --- a/build/check.xsl +++ b/build/check.xsl @@ -23,73 +23,18 @@ xmlns="urn:oasis:names:tc:SAML:2.0:metadata"> - - + + - + - - - - - - - - - - - - - duplicate entityID: - - - - - - - - - - - - duplicate OrganisationDisplayName: - - - - - - - - - - - - - entity lacks OrganizationName - - - - - - - OrganizationURL '' does not start with acceptable prefix - - - - - - - - Shibboleth 1.x auth request needs urn:oasis:names:tc:SAML:1.1:protocol in IDPSSODescriptor/@protocolSupportEnumeration - - - - - - Shibboleth 1.x auth request needs urn:mace:shibboleth:1.0 in IDPSSODescriptor/@protocolSupportEnumeration - - - - - - - - - IdP SSO KeyDescriptor lacking @use - - - - - - IdP AA KeyDescriptor lacking @use - - - - - - - - - IdP SSO Descriptor lacking KeyDescriptor - - - - - - SP SSO Descriptor lacking KeyDescriptor - - - - - - IdP AA Descriptor lacking KeyDescriptor - - - - - - - - ds:KeyInfo child element not in ds namespace - - - - - - - - SIDPO-34: Attribute lacking NameFormat in IDPSSODescriptor - - - - - - - - entity ID contains space character - - - - - - - - entity ID does not start with acceptable prefix - - - - - - - - Location contains space character - - - - - - - - - missing Binding attribute on DiscoveryResponse - - - - - - incorrect Binding value on DiscoveryResponse - - - - - - - - Location does not start with https:// - - - - @@ -302,53 +57,4 @@ - - - - Scope lacks @regexp - - - - - - - - empty xml:lang attribute - - - - - - - - - - *** - - : - - - - - - - - - - - - - - - diff --git a/build/check_framework.xsl b/build/check_framework.xsl new file mode 100644 index 00000000..b673682d --- /dev/null +++ b/build/check_framework.xsl @@ -0,0 +1,66 @@ + + + + + + + + + + + + + + *** + + + + + + + + + + + + : + + + + + + + + + + + + + + + + + + diff --git a/build/check_idpdisc.xsl b/build/check_idpdisc.xsl new file mode 100644 index 00000000..a42ee1d9 --- /dev/null +++ b/build/check_idpdisc.xsl @@ -0,0 +1,42 @@ + + + + + + + + + + + + + missing Binding attribute on DiscoveryResponse + + + + + + incorrect Binding value on DiscoveryResponse + + + + + diff --git a/build/check_imported.xsl b/build/check_imported.xsl index 9e18504a..6955e945 100644 --- a/build/check_imported.xsl +++ b/build/check_imported.xsl @@ -3,8 +3,7 @@ check_imported.xsl - XSL stylesheet that takes an imported metadata document destined for - the UK federation and checks it against local conventions. + Checking ruleset containing rules associated with imported metadata. Author: Ian A. Young @@ -21,258 +20,12 @@ xmlns="urn:oasis:names:tc:SAML:2.0:metadata"> - - - - - - entity lacks OrganizationName - - - + - - - OrganizationURL '' does not start with acceptable prefix - - - - - - - - Shibboleth 1.x auth request needs urn:oasis:names:tc:SAML:1.1:protocol in IDPSSODescriptor/@protocolSupportEnumeration - - - - - - Shibboleth 1.x auth request needs urn:mace:shibboleth:1.0 in IDPSSODescriptor/@protocolSupportEnumeration - - - - - - - - - IdP SSO KeyDescriptor lacking @use - - - - - - IdP AA KeyDescriptor lacking @use - - - - - - - - - IdP SSO Descriptor lacking KeyDescriptor - - - - - - SP SSO Descriptor lacking KeyDescriptor - - - - - - IdP AA Descriptor lacking KeyDescriptor - - - - - - - - ds:KeyInfo child element not in ds namespace - - - - - - - - SIDPO-34: Attribute lacking NameFormat in IDPSSODescriptor - - - - - - - - entity ID contains space character - - - - - - - - entity ID does not start with acceptable prefix - - - - - - - - Location contains space character - - - - - - - - - missing Binding attribute on DiscoveryResponse - - - - - - incorrect Binding value on DiscoveryResponse - - - - - - - - Location does not start with https:// - - - - - - - - Scope lacks @regexp - - - - - - - - empty xml:lang attribute - - - - - - - - - *** - - : - - - - - - - - - - - - - - diff --git a/build/check_misc.xsl b/build/check_misc.xsl new file mode 100644 index 00000000..42f54668 --- /dev/null +++ b/build/check_misc.xsl @@ -0,0 +1,168 @@ + + + + + + + + + + + + + + + + + + + + + duplicate entityID: + + + + + + + + + + + + duplicate OrganisationDisplayName: + + + + + + + + + + + + + entity lacks OrganizationName + + + + + + + + + IdP SSO Descriptor lacking KeyDescriptor + + + + + + SP SSO Descriptor lacking KeyDescriptor + + + + + + IdP AA Descriptor lacking KeyDescriptor + + + + + + + + entity ID contains space character + + + + + + + + entity ID does not start with acceptable prefix + + + + + + + + Location contains space character + + + + + + + + Location does not start with https:// + + + + + + + + empty xml:lang attribute + + + + diff --git a/build/check_shibboleth.xsl b/build/check_shibboleth.xsl new file mode 100644 index 00000000..c2e33385 --- /dev/null +++ b/build/check_shibboleth.xsl @@ -0,0 +1,140 @@ + + + + + + + + + + + + OrganizationURL '' does not start with acceptable prefix + + + + + + + + Shibboleth 1.x auth request needs urn:oasis:names:tc:SAML:1.1:protocol in IDPSSODescriptor/@protocolSupportEnumeration + + + + + + Shibboleth 1.x auth request needs urn:mace:shibboleth:1.0 in IDPSSODescriptor/@protocolSupportEnumeration + + + + + + + + + IdP SSO KeyDescriptor lacking @use + + + + + + IdP AA KeyDescriptor lacking @use + + + + + + + + ds:KeyInfo child element not in ds namespace + + + + + + + + SIDPO-34: Attribute lacking NameFormat in IDPSSODescriptor + + + + + + + + Scope lacks @regexp + + + + + diff --git a/tools/mdcheck/lib/sdss-mdcheck-1.1.jar b/tools/mdcheck/lib/sdss-mdcheck-1.1.jar deleted file mode 100644 index 470ce9c6..00000000 Binary files a/tools/mdcheck/lib/sdss-mdcheck-1.1.jar and /dev/null differ diff --git a/tools/mdcheck/lib/sdss-mdcheck-1.2.jar b/tools/mdcheck/lib/sdss-mdcheck-1.2.jar new file mode 100644 index 00000000..47001af6 Binary files /dev/null and b/tools/mdcheck/lib/sdss-mdcheck-1.2.jar differ