From e376fbd1e5cf355dcf84954887b199ce2a8b3edb Mon Sep 17 00:00:00 2001
From: Ian Young <ian@iay.org.uk>
Date: Mon, 15 Feb 2010 10:58:02 +0000
Subject: [PATCH] Check for OrganizationURL elements that don't contain
 properly formatted URLs.

---
 build/check.xsl          | 17 +++++++++++++++++
 build/check_imported.xsl | 17 +++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/build/check.xsl b/build/check.xsl
index 3d23a5ae..fd142c54 100644
--- a/build/check.xsl
+++ b/build/check.xsl
@@ -102,6 +102,23 @@
 	</xsl:template>
 	
 	
+	<!--
+		OrganizationURL elements should contain actual URLs, or some software
+		will reject the metadata.  This is known to be true for at least the Shibboleth
+		1.3 IdP and the accompanying metadatatool application, because they pass the
+		string to the java.net.URL class.
+		
+		We perform a very cursory test for this by insisting that they start with
+		either "http://" or "https://".
+	-->
+	<xsl:template match="md:OrganizationURL[not(starts-with(., 'http://'))]
+		[not(starts-with(., 'https://'))]">
+		<xsl:call-template name="fatal">
+			<xsl:with-param name="m">OrganizationURL '<xsl:value-of select="."/>' does not start with acceptable prefix</xsl:with-param>
+		</xsl:call-template>
+	</xsl:template>
+	
+	
 	<!--
 		Checks for an IdP whose KeyDescriptor elements do not include a @use attribute.
 		This causes problems with the Shibboleth 1.3 SP prior to V1.3.1, which
diff --git a/build/check_imported.xsl b/build/check_imported.xsl
index 00aeb60e..e7fd8e13 100644
--- a/build/check_imported.xsl
+++ b/build/check_imported.xsl
@@ -37,6 +37,23 @@
 	</xsl:template>
 
 
+	<!--
+		OrganizationURL elements should contain actual URLs, or some software
+		will reject the metadata.  This is known to be true for at least the Shibboleth
+		1.3 IdP and the accompanying metadatatool application, because they pass the
+		string to the java.net.URL class.
+		
+		We perform a very cursory test for this by insisting that they start with
+		either "http://" or "https://".
+	-->
+	<xsl:template match="md:OrganizationURL[not(starts-with(., 'http://'))]
+		[not(starts-with(., 'https://'))]">
+		<xsl:call-template name="fatal">
+			<xsl:with-param name="m">OrganizationURL '<xsl:value-of select="."/>' does not start with acceptable prefix</xsl:with-param>
+		</xsl:call-template>
+	</xsl:template>
+	
+	
 	<!--
 		Checks for an IdP whose KeyDescriptor elements do not include a @use attribute.
 		This causes problems with the Shibboleth 1.3 SP prior to V1.3.1, which