From 0d115f98c785b800787246ba7a8bd7916d455651 Mon Sep 17 00:00:00 2001 From: Jj! Date: Wed, 13 Feb 2019 16:26:01 -0600 Subject: [PATCH] [SHIBUI-1226] implemented update for ACSs --- .../admin/ui/service/JPAEntityDescriptorServiceImpl.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java index 7652541c8..c3d434927 100644 --- a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java +++ b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java @@ -269,6 +269,8 @@ private EntityDescriptor buildDescriptorFromRepresentation(final EntityDescripto // setup ACSs if (representation.getAssertionConsumerServices() != null && representation.getAssertionConsumerServices().size() > 0) { + // TODO: review if we need more than a naive implementation + getOptionalSPSSODescriptorFromEntityDescriptor(ed).ifPresent(spssoDescriptor -> spssoDescriptor.getAssertionConsumerServices().clear()); for (AssertionConsumerServiceRepresentation acsRepresentation : representation.getAssertionConsumerServices()) { AssertionConsumerService assertionConsumerService = openSamlObjects.buildDefaultInstanceOfType(AssertionConsumerService.class); getSPSSODescriptorFromEntityDescriptor(ed).getAssertionConsumerServices().add(assertionConsumerService); @@ -279,7 +281,7 @@ private EntityDescriptor buildDescriptorFromRepresentation(final EntityDescripto assertionConsumerService.setLocation(acsRepresentation.getLocationUrl()); } } else { - // TODO: implement + getOptionalSPSSODescriptorFromEntityDescriptor(ed).ifPresent(spssoDescriptor -> spssoDescriptor.getAssertionConsumerServices().clear()); } // setup logout