From 7684867a3cf49cf7fb473a504e02eed8f280b9a8 Mon Sep 17 00:00:00 2001
From: Ryan Mathis <rmathis@unicon.net>
Date: Thu, 7 Jul 2022 12:27:36 -0700
Subject: [PATCH 1/2] Added success alert for custom entity attributes

---
 ui/public/assets/schema/attribute/attribute.schema.json | 2 +-
 ui/src/app/metadata/new/NewAttribute.js                 | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/ui/public/assets/schema/attribute/attribute.schema.json b/ui/public/assets/schema/attribute/attribute.schema.json
index 0514703f0..84590e08e 100644
--- a/ui/public/assets/schema/attribute/attribute.schema.json
+++ b/ui/public/assets/schema/attribute/attribute.schema.json
@@ -64,7 +64,7 @@
             "title": "label.entity-attribute-help",
             "description": "tooltip.entity-attribute-help",
             "type": "string",
-            "minLength": 1,
+            "minLength": 0,
             "maxLength": 255
         }
     },
diff --git a/ui/src/app/metadata/new/NewAttribute.js b/ui/src/app/metadata/new/NewAttribute.js
index 3648942bb..0db6847cb 100644
--- a/ui/src/app/metadata/new/NewAttribute.js
+++ b/ui/src/app/metadata/new/NewAttribute.js
@@ -11,7 +11,7 @@ import { useMetadataAttribute } from '../hooks/api';
 import {CustomAttributeDefinition} from '../domain/attribute/CustomAttributeDefinition';
 import MetadataSchema from '../hoc/MetadataSchema';
 import { MetadataForm } from '../hoc/MetadataFormContext';
-import { createNotificationAction, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
+import { createNotificationAction, NotificationTypes, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
 
 export function NewAttribute() {
     const history = useHistory();
@@ -25,11 +25,16 @@ export function NewAttribute() {
     const [blocking, setBlocking] = React.useState(false);
 
     async function save(metadata) {
+        let toast;
         const resp = await post(``, definition.parser(metadata));
         if (response.ok) {
+            toast =  createNotificationAction(`Added attribute successfully.`, NotificationTypes.SUCCESS);
             gotoDetail({ refresh: true });
         } else {
-            dispatch(createNotificationAction(`${resp.errorCode}: Unable to create attribute ... ${resp.errorMessage}`, 'danger', 5000));
+            toast = createNotificationAction(`${resp.errorCode}: Unable to create attribute ... ${resp.errorMessage}`, 'danger', 5000);
+        }
+        if (toast) {
+            dispatch(toast);
         }
     };
 

From be660ed0c48a542fe61796f8f5e2704f5ea84fee Mon Sep 17 00:00:00 2001
From: Ryan Mathis <rmathis@unicon.net>
Date: Thu, 7 Jul 2022 12:34:44 -0700
Subject: [PATCH 2/2] Added success notifcation for editing/deleting attributes

---
 ui/src/app/metadata/hoc/MetadataAttributes.js     | 4 ++++
 ui/src/app/metadata/view/MetadataAttributeEdit.js | 9 +++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/ui/src/app/metadata/hoc/MetadataAttributes.js b/ui/src/app/metadata/hoc/MetadataAttributes.js
index c4c59d3c0..e4cf57a2d 100644
--- a/ui/src/app/metadata/hoc/MetadataAttributes.js
+++ b/ui/src/app/metadata/hoc/MetadataAttributes.js
@@ -1,8 +1,11 @@
 import React from 'react';
+import { createNotificationAction, NotificationTypes, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
 import { useMetadataAttribute, useMetadataAttributes } from '../hooks/api';
 
 export function MetadataAttributes ({children}) {
 
+     const dispatch = useNotificationDispatcher();
+
     const { get, response } = useMetadataAttributes({
         cachePolicy: 'no-cache'
     });
@@ -24,6 +27,7 @@ export function MetadataAttributes ({children}) {
         await del(`/${id}`);
         if (attrApi.response.ok) {
             loadAttributes();
+            dispatch(createNotificationAction(`Attribute deleted successfully`, NotificationTypes.SUCCESS, 5000));
         }
     }
 
diff --git a/ui/src/app/metadata/view/MetadataAttributeEdit.js b/ui/src/app/metadata/view/MetadataAttributeEdit.js
index b45dfeaa5..84670d467 100644
--- a/ui/src/app/metadata/view/MetadataAttributeEdit.js
+++ b/ui/src/app/metadata/view/MetadataAttributeEdit.js
@@ -11,7 +11,7 @@ import { useMetadataAttribute } from '../hooks/api';
 import { CustomAttributeDefinition, CustomAttributeEditor } from '../domain/attribute/CustomAttributeDefinition';
 import MetadataSchema from '../hoc/MetadataSchema';
 import { MetadataForm } from '../hoc/MetadataFormContext';
-import { createNotificationAction, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
+import { createNotificationAction, NotificationTypes, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
 
 export function MetadataAttributeEdit() {
     const { id } = useParams();
@@ -35,11 +35,16 @@ export function MetadataAttributeEdit() {
     }
 
     async function save(metadata) {
+        let toast;
         const resp = await put(``, definition.parser(metadata));
         if (response.ok) {
+            toast =  createNotificationAction(`Updated attribute successfully.`, NotificationTypes.SUCCESS);
             gotoDetail({ refresh: true });
         } else {
-            dispatch(createNotificationAction(`${resp.errorCode}: Unable to edit attribute ... ${resp.errorMessage}`, 'danger', 5000));
+            toast = createNotificationAction(`${resp.errorCode}: Unable to edit attribute ... ${resp.errorMessage}`, 'danger', 5000);
+        }
+        if (toast) {
+            dispatch(toast);
         }
     };