From 12173e6ddfaee0f28b613fea059b435191868223 Mon Sep 17 00:00:00 2001 From: Ryan Mathis Date: Wed, 19 May 2021 08:41:33 -0700 Subject: [PATCH] cleaned up warnings --- ui/src/app/form/component/fields/FilterTargetField.js | 3 +-- ui/src/app/metadata/Metadata.js | 1 - ui/src/app/metadata/domain/filter/BaseFilterDefinition.js | 2 -- ui/src/app/metadata/domain/filter/NameIdFilterDefinition.js | 2 +- ui/src/app/metadata/editor/MetadataFilterEditor.js | 4 ++-- ui/src/app/metadata/wizard/MetadataFilterTypeSelector.js | 2 +- 6 files changed, 5 insertions(+), 9 deletions(-) diff --git a/ui/src/app/form/component/fields/FilterTargetField.js b/ui/src/app/form/component/fields/FilterTargetField.js index 7ea27429b..9483d861a 100644 --- a/ui/src/app/form/component/fields/FilterTargetField.js +++ b/ui/src/app/form/component/fields/FilterTargetField.js @@ -1,9 +1,8 @@ import React from 'react'; -import Form from 'react-bootstrap/Form'; import Dropdown from 'react-bootstrap/Dropdown'; import Translate from '../../../i18n/components/translate'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; -import { faAsterisk, faCaretDown, faCaretUp, faCheck, faPlus, faTimes, faTrash } from '@fortawesome/free-solid-svg-icons'; +import { faAsterisk, faCaretDown, faCaretUp, faPlus, faTrash } from '@fortawesome/free-solid-svg-icons'; import { useTranslator } from '../../../i18n/hooks'; import { InfoIcon } from '../InfoIcon'; import ContentEditable from 'react-contenteditable'; diff --git a/ui/src/app/metadata/Metadata.js b/ui/src/app/metadata/Metadata.js index 40cde87ce..dc00b0e7f 100644 --- a/ui/src/app/metadata/Metadata.js +++ b/ui/src/app/metadata/Metadata.js @@ -10,7 +10,6 @@ import { MetadataXml } from './view/MetadataXml'; import { MetadataComparison } from './view/MetadataComparison'; import { MetadataVersion } from './view/MetadataVersion'; import { MetadataEdit } from './view/MetadataEdit'; -import { Filter } from './Filter'; export function Metadata () { diff --git a/ui/src/app/metadata/domain/filter/BaseFilterDefinition.js b/ui/src/app/metadata/domain/filter/BaseFilterDefinition.js index 0cd16ce20..16d2cf7fc 100644 --- a/ui/src/app/metadata/domain/filter/BaseFilterDefinition.js +++ b/ui/src/app/metadata/domain/filter/BaseFilterDefinition.js @@ -1,5 +1,3 @@ -import { removeNull } from "../../../core/utility/remove_null"; - export const BaseFilterDefinition = { parser: (changes) => changes, formatter: (changes) => changes, diff --git a/ui/src/app/metadata/domain/filter/NameIdFilterDefinition.js b/ui/src/app/metadata/domain/filter/NameIdFilterDefinition.js index 488b87771..89f9f6ffd 100644 --- a/ui/src/app/metadata/domain/filter/NameIdFilterDefinition.js +++ b/ui/src/app/metadata/domain/filter/NameIdFilterDefinition.js @@ -22,7 +22,7 @@ export const NameIDFilterWizard = { const names = filters.map(s => s.entityId); return (formData, errors) => { - if (filters.indexOf(formData.name) > -1) { + if (names.indexOf(formData.name) > -1) { errors.name.addError('message.name-unique'); } diff --git a/ui/src/app/metadata/editor/MetadataFilterEditor.js b/ui/src/app/metadata/editor/MetadataFilterEditor.js index e5ff27b70..90c7ed8d7 100644 --- a/ui/src/app/metadata/editor/MetadataFilterEditor.js +++ b/ui/src/app/metadata/editor/MetadataFilterEditor.js @@ -1,7 +1,7 @@ import React from 'react'; -import { faExclamationTriangle, faSave, faSpinner } from '@fortawesome/free-solid-svg-icons'; +import { faExclamationTriangle } from '@fortawesome/free-solid-svg-icons'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; -import { useHistory, useParams, Prompt } from 'react-router'; +import { useHistory, useParams } from 'react-router'; import Alert from 'react-bootstrap/Alert'; import Translate from '../../i18n/components/translate'; diff --git a/ui/src/app/metadata/wizard/MetadataFilterTypeSelector.js b/ui/src/app/metadata/wizard/MetadataFilterTypeSelector.js index 287119000..f582f2eb9 100644 --- a/ui/src/app/metadata/wizard/MetadataFilterTypeSelector.js +++ b/ui/src/app/metadata/wizard/MetadataFilterTypeSelector.js @@ -9,7 +9,7 @@ export function MetadataFilterTypeSelector({ types = [], children, actions}) { const translator = useTranslator(); - const { register, handleSubmit, getValues, watch } = useForm({ + const { register, handleSubmit, watch } = useForm({ mode: 'onChange', reValidateMode: 'onChange', defaultValues: {