From 1c8e24eff76e5df7a956f5ddf4f6e7c26c1eff0c Mon Sep 17 00:00:00 2001
From: Ryan Mathis <rmathis@unicon.net>
Date: Thu, 17 Jun 2021 15:43:34 -0700
Subject: [PATCH] Fixed cache, added error messages

---
 ui/src/app/App.js                                          | 1 +
 .../form/component/fields/StringListWithDefaultField.js    | 2 +-
 ui/src/app/metadata/new/NewAttribute.js                    | 7 ++++++-
 ui/src/app/metadata/view/MetadataAttributeEdit.js          | 7 ++++++-
 4 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/ui/src/app/App.js b/ui/src/app/App.js
index 097c0095d..5d0c4e1e4 100644
--- a/ui/src/app/App.js
+++ b/ui/src/app/App.js
@@ -34,6 +34,7 @@ function App() {
     const [showTimeout] = React.useState();
 
     const httpOptions = {
+        cachePolicy: 'no-cache',
         redirect: 'manual',
         interceptors: {
             request: async ({options, url, path, route}) => {
diff --git a/ui/src/app/form/component/fields/StringListWithDefaultField.js b/ui/src/app/form/component/fields/StringListWithDefaultField.js
index 3f8ba8b74..c29fe31d2 100644
--- a/ui/src/app/form/component/fields/StringListWithDefaultField.js
+++ b/ui/src/app/form/component/fields/StringListWithDefaultField.js
@@ -121,7 +121,7 @@ const StringListWithDefaultField = ({
                     </div>
                     <div>
                         {items && items.map((p, idx) =>
-                            <div className="my-2 d-flex justify-content-between align-items-center form-inline">
+                            <div key={idx} className="my-2 d-flex justify-content-between align-items-center form-inline">
                                 <Form.Control
                                     type="text"
                                     className="flex-grow-1"
diff --git a/ui/src/app/metadata/new/NewAttribute.js b/ui/src/app/metadata/new/NewAttribute.js
index 41d7ace0e..9c01eb55d 100644
--- a/ui/src/app/metadata/new/NewAttribute.js
+++ b/ui/src/app/metadata/new/NewAttribute.js
@@ -11,10 +11,13 @@ import { useMetadataAttribute } from '../hooks/api';
 import {CustomAttributeDefinition} from '../domain/attribute/CustomAttributeDefinition';
 import MetadataSchema from '../hoc/MetadataSchema';
 import { MetadataForm } from '../hoc/MetadataFormContext';
+import { createNotificationAction, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
 
 export function NewAttribute() {
     const history = useHistory();
 
+    const dispatch = useNotificationDispatcher();
+
     const definition = CustomAttributeDefinition;
 
     const { post, response, loading } = useMetadataAttribute({});
@@ -22,9 +25,11 @@ export function NewAttribute() {
     const [blocking, setBlocking] = React.useState(false);
 
     async function save(metadata) {
-        await post(``, definition.parser(metadata));
+        const resp = await post(``, definition.parser(metadata));
         if (response.ok) {
             gotoDetail({ refresh: true });
+        } else {
+            dispatch(createNotificationAction(`${resp.errorCode}: Unable to create attribute ... ${resp.errorMessage}`, 'danger', 5000));
         }
     };
 
diff --git a/ui/src/app/metadata/view/MetadataAttributeEdit.js b/ui/src/app/metadata/view/MetadataAttributeEdit.js
index 58cd6d995..d0c04f287 100644
--- a/ui/src/app/metadata/view/MetadataAttributeEdit.js
+++ b/ui/src/app/metadata/view/MetadataAttributeEdit.js
@@ -11,6 +11,7 @@ import { useMetadataAttribute } from '../hooks/api';
 import { CustomAttributeDefinition, CustomAttributeEditor } from '../domain/attribute/CustomAttributeDefinition';
 import MetadataSchema from '../hoc/MetadataSchema';
 import { MetadataForm } from '../hoc/MetadataFormContext';
+import { createNotificationAction, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
 
 export function MetadataAttributeEdit() {
     const { id } = useParams();
@@ -18,6 +19,8 @@ export function MetadataAttributeEdit() {
 
     const definition = CustomAttributeDefinition;
 
+    const dispatch = useNotificationDispatcher();
+
     const { get, put, response, loading } = useMetadataAttribute({
         cachePolicy: 'no-cache'
     });
@@ -32,9 +35,11 @@ export function MetadataAttributeEdit() {
     }
 
     async function save(metadata) {
-        await put(``, definition.parser(metadata));
+        const resp = await put(``, definition.parser(metadata));
         if (response.ok) {
             gotoDetail({ refresh: true });
+        } else {
+            dispatch(createNotificationAction(`${resp.errorCode}: Unable to edit attribute ... ${resp.errorMessage}`, 'danger', 5000));
         }
     };