From 1eeff24488f634b2e57c39b0277da98ac2637e59 Mon Sep 17 00:00:00 2001 From: Dmitriy Kopylenko Date: Fri, 17 Aug 2018 11:24:22 -0400 Subject: [PATCH] SHIBUI-754: wip --- .../MetadataFiltersPositionOrderController.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java index 71af40f95..2763eae89 100644 --- a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java +++ b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java @@ -47,10 +47,14 @@ public ResponseEntity updateFiltersPositionOrder(@PathVariable String metadat .ifPresent(reOrderedFilters::add) ); - resolver.setMetadataFilters(reOrderedFilters); - metadataResolverRepository.save(resolver); - - return ResponseEntity.noContent().build(); + if(currentFilters.size() == reOrderedFilters.size()) { + resolver.setMetadataFilters(reOrderedFilters); + metadataResolverRepository.save(resolver); + return ResponseEntity.noContent().build(); + } + return ResponseEntity + .badRequest() + .body("Number of filters to reorder or filters resource ids do not match current filters"); } @GetMapping