From 32a8b8708020d18ad8d446a05483a5df6be511a6 Mon Sep 17 00:00:00 2001 From: Ryan Mathis Date: Tue, 2 Nov 2021 13:56:32 -0700 Subject: [PATCH 1/3] Fixed is issue with select boxes --- ui/src/app/form/component/widgets/SelectWidget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/app/form/component/widgets/SelectWidget.js b/ui/src/app/form/component/widgets/SelectWidget.js index a2ad763e6..4a00dbbf3 100644 --- a/ui/src/app/form/component/widgets/SelectWidget.js +++ b/ui/src/app/form/component/widgets/SelectWidget.js @@ -127,7 +127,7 @@ const SelectWidget = ({ )} {(enumOptions).map(({ value, label }, i) => - )} From 5ff7c6fbecfc7cef1462377449a7bacbcd3c6072 Mon Sep 17 00:00:00 2001 From: Bill Smith Date: Tue, 2 Nov 2021 14:43:40 -0700 Subject: [PATCH 2/3] 2250 WIP test fixing for CEA Lists. --- .../integration/resources/SHIBUI-1732-3.side | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/backend/src/integration/resources/SHIBUI-1732-3.side b/backend/src/integration/resources/SHIBUI-1732-3.side index 6a3927fda..d7a65246c 100644 --- a/backend/src/integration/resources/SHIBUI-1732-3.side +++ b/backend/src/integration/resources/SHIBUI-1732-3.side @@ -685,12 +685,38 @@ ["xpath=//section[7]/div/div/div/button", "xpath:position"] ], "value": "" + }, { + "id": "5491ac17-6d58-4fe3-861a-06bc89470aa5", + "comment": "", + "command": "pause", + "target": "1000", + "targets": [], + "value": "" + }, { + "id": "65be7a0b-462f-43be-9e2f-c7dc71f15467", + "comment": "", + "command": "select", + "target": "id=root_relyingPartyOverrides_CustomList_0", + "targets": [ + ["id=root_relyingPartyOverrides_CustomList_0", "id"], + ["css=#root_relyingPartyOverrides_CustomList_0", "css:finder"], + ["xpath=//select[@id='root_relyingPartyOverrides_CustomList_0']", "xpath:attributes"], + ["xpath=//div[@id='root']/div/main/div/section/div[2]/div[2]/div[2]/div/form/div/div/div/div/div[8]/div/div/div/div[6]/div/div/div/div/div/div[2]/div/div/div/div/div/div/select", "xpath:idRelative"], + ["xpath=//select", "xpath:position"] + ], + "value": "label=foo" }, { "id": "e4abb650-c762-4060-bc81-428b4758f08e", "comment": "", "command": "select", "target": "id=root_relyingPartyOverrides_CustomList_0", - "targets": [], + "targets": [ + ["id=root_relyingPartyOverrides_CustomList_0", "id"], + ["css=#root_relyingPartyOverrides_CustomList_0", "css:finder"], + ["xpath=//select[@id='root_relyingPartyOverrides_CustomList_0']", "xpath:attributes"], + ["xpath=//div[@id='root']/div/main/div/section/div[2]/div[2]/div[2]/div/form/div/div/div/div/div[8]/div/div/div/div[6]/div/div/div/div/div/div[2]/div/div/div/div/div/div/select", "xpath:idRelative"], + ["xpath=//select", "xpath:position"] + ], "value": "label=foo" }, { "id": "992e127d-5ac1-4796-b54f-f212683624ac", From 0370b0eca69df401d66b5db31543c48dfce4e3f3 Mon Sep 17 00:00:00 2001 From: Bill Smith Date: Wed, 3 Nov 2021 14:14:05 -0700 Subject: [PATCH 3/3] 2250 Some more fixes. Why are select boxes requiring double clicks sometimes? --- .../src/integration/resources/SHIBUI-1732-1.side | 14 ++++++++++++++ .../src/integration/resources/SHIBUI-1732-2.side | 7 +++++++ .../src/integration/resources/SHIBUI-1732-3.side | 9 ++++++++- .../src/integration/resources/SHIBUI-1732-4.side | 7 +++++++ .../src/integration/resources/SHIBUI-1732-5.side | 7 +++++++ .../src/integration/resources/SHIBUI-1732-6.side | 7 +++++++ .../src/integration/resources/SHIBUI-1732-7.side | 7 +++++++ 7 files changed, 57 insertions(+), 1 deletion(-) diff --git a/backend/src/integration/resources/SHIBUI-1732-1.side b/backend/src/integration/resources/SHIBUI-1732-1.side index 0cfa6d961..b898f8bf9 100644 --- a/backend/src/integration/resources/SHIBUI-1732-1.side +++ b/backend/src/integration/resources/SHIBUI-1732-1.side @@ -584,6 +584,13 @@ ["xpath=//a[contains(.,'Add a new metadata provider')]", "xpath:innerText"] ], "value": "" + }, { + "id": "bb1d9d3f-631a-40eb-8f51-bd502a90c2b2", + "comment": "", + "command": "waitForElementEditable", + "target": "name=type", + "targets": [], + "value": "30000" }, { "id": "c6e4f105-81ce-4132-b82b-d28d11f27746", "comment": "", @@ -597,6 +604,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "7a088a82-2f0c-4466-9304-60c7c504913c", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "2c98e69c-d595-48a7-ac67-eca5d9f3a784", "comment": "", diff --git a/backend/src/integration/resources/SHIBUI-1732-2.side b/backend/src/integration/resources/SHIBUI-1732-2.side index a51946374..3b3777779 100644 --- a/backend/src/integration/resources/SHIBUI-1732-2.side +++ b/backend/src/integration/resources/SHIBUI-1732-2.side @@ -564,6 +564,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "9a4b3759-61b9-478a-9888-00e512721d4f", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "7c10b23a-a427-4cc4-bae9-9e5606712b6e", "comment": "", diff --git a/backend/src/integration/resources/SHIBUI-1732-3.side b/backend/src/integration/resources/SHIBUI-1732-3.side index 1bffbb634..5a794676b 100644 --- a/backend/src/integration/resources/SHIBUI-1732-3.side +++ b/backend/src/integration/resources/SHIBUI-1732-3.side @@ -834,6 +834,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "f21989e9-8b54-4e55-a6f7-c699939f0992", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "3c298664-b8c4-40de-986e-a955c760ba3e", "comment": "", @@ -1557,4 +1564,4 @@ }], "urls": ["http://localhost:10101/"], "plugins": [] -} +} \ No newline at end of file diff --git a/backend/src/integration/resources/SHIBUI-1732-4.side b/backend/src/integration/resources/SHIBUI-1732-4.side index 230d81fb4..5c7260a30 100644 --- a/backend/src/integration/resources/SHIBUI-1732-4.side +++ b/backend/src/integration/resources/SHIBUI-1732-4.side @@ -578,6 +578,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "94bd599c-4de3-4f7c-b28b-719012acf8b5", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "befba204-65a3-4a26-91ca-75141306ee8a", "comment": "", diff --git a/backend/src/integration/resources/SHIBUI-1732-5.side b/backend/src/integration/resources/SHIBUI-1732-5.side index 4b312029e..a74508f17 100644 --- a/backend/src/integration/resources/SHIBUI-1732-5.side +++ b/backend/src/integration/resources/SHIBUI-1732-5.side @@ -578,6 +578,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "12eebf6a-616b-4bb3-af32-aad829ba1133", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "577b9b53-a904-419f-b0d8-4e899aaee297", "comment": "", diff --git a/backend/src/integration/resources/SHIBUI-1732-6.side b/backend/src/integration/resources/SHIBUI-1732-6.side index e91d21c6c..e90e128f2 100644 --- a/backend/src/integration/resources/SHIBUI-1732-6.side +++ b/backend/src/integration/resources/SHIBUI-1732-6.side @@ -578,6 +578,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "c8293710-35ad-4ac6-a175-33ca8fcab2ff", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "a26d50d7-f81f-4fbe-9942-804853b58f19", "comment": "", diff --git a/backend/src/integration/resources/SHIBUI-1732-7.side b/backend/src/integration/resources/SHIBUI-1732-7.side index 08a70a4a6..fd55d0449 100644 --- a/backend/src/integration/resources/SHIBUI-1732-7.side +++ b/backend/src/integration/resources/SHIBUI-1732-7.side @@ -554,6 +554,13 @@ ["xpath=//input", "xpath:position"] ], "value": "Test" + }, { + "id": "506e9329-0c23-449b-b285-96541b2fa557", + "comment": "", + "command": "select", + "target": "name=type", + "targets": [], + "value": "label=FileBackedHttpMetadataResolver" }, { "id": "f26372d3-0701-4cc3-9746-8f96175686e6", "comment": "",