Required for Regex
@@ -249,7 +249,25 @@ const FilterTargetField = ({
}
>
}
-
+ {targetType === 'CONDITION_REF' &&
+ <>
+ handleTextChange(value) } />
+ {errorSchema?.value?.__errors ?
+
+ {errors}
+ :
+
+ Required for Condition Ref
+
+
+ }
+ >
+ }
{targetType === 'ENTITY' &&
diff --git a/ui/src/app/metadata/Filter.js b/ui/src/app/metadata/Filter.js
index 4c1bc707c..58b867040 100644
--- a/ui/src/app/metadata/Filter.js
+++ b/ui/src/app/metadata/Filter.js
@@ -11,6 +11,8 @@ export function Filter() {
const { path, url } = useRouteMatch();
+ console.log(path, url)
+
return (
diff --git a/ui/src/app/metadata/domain/filter/definition/AlgorithmFilterDefinition.js b/ui/src/app/metadata/domain/filter/definition/AlgorithmFilterDefinition.js
index 4841b5c89..51e3fa846 100644
--- a/ui/src/app/metadata/domain/filter/definition/AlgorithmFilterDefinition.js
+++ b/ui/src/app/metadata/domain/filter/definition/AlgorithmFilterDefinition.js
@@ -1,6 +1,5 @@
import defaultsDeep from "lodash/defaultsDeep";
-// import API_BASE_PATH from "../../../../App.constant";
-import { BASE_PATH } from '../../../../App.constant';
+import API_BASE_PATH from "../../../../App.constant";
import { BaseFilterDefinition } from "./BaseFilterDefinition";
export const AlgorithmFilterWizard = {
@@ -10,19 +9,16 @@ export const AlgorithmFilterWizard = {
'ui:field': 'FilterTargetField',
api: ''
},
- formats: {
+ algorithms: {
"ui:options": {
orderable: false
- },
- items: {
- 'ui:widget': 'OptionWidget'
}
}
}, BaseFilterDefinition.uiSchema),
label: 'Algorithm',
type: 'Algorithm',
- // schema: `${API_BASE_PATH}/ui/AlgorithmFilter`,
- schema: `${BASE_PATH}assets/schema/filter/algorithm.schema.json`,
+ schema: `${API_BASE_PATH}/ui/AlgorithmFilter`,
+ // schema: `${BASE_PATH}assets/schema/filter/algorithm.schema.json`,
steps: [],
validator: (data = [], current = { resourceId: null }, group) => {
return BaseFilterDefinition.validator(data, current, group, 'algorithmFilterTarget', 'algorithmFilterTargetType')
@@ -54,7 +50,7 @@ export const AlgorithmFilterEditor = {
index: 2,
initialValues: [],
fields: [
- 'algorithm'
+ 'algorithms'
]
}
]
diff --git a/ui/src/app/metadata/domain/filter/definition/BaseFilterDefinition.js b/ui/src/app/metadata/domain/filter/definition/BaseFilterDefinition.js
index daed4cadc..1f8191cdc 100644
--- a/ui/src/app/metadata/domain/filter/definition/BaseFilterDefinition.js
+++ b/ui/src/app/metadata/domain/filter/definition/BaseFilterDefinition.js
@@ -29,6 +29,13 @@ export const BaseFilterDefinition = {
errors[targetProp].value.addError('message.required-for-scripts');
}
}
+
+ if (formData[targetProp][typeProp] === 'CONDITION_REF') {
+ const { [targetProp]: { value } } = formData;
+ if (!value[0]) {
+ errors[targetProp].value.addError('message.required-for-condition-ref');
+ }
+ }
}
return errors;