From 63433bec6f68a7ce18554c174a880daaf9b7d36d Mon Sep 17 00:00:00 2001 From: Jodie Muramoto Date: Thu, 15 Nov 2018 15:37:49 -0700 Subject: [PATCH 1/2] SHIBUI-954: Fixed the tooltip to append to container body and added a column space on the right of the forms for better tooltip presentation; --- .../resolver/container/resolver-wizard.component.html | 6 ++++-- ui/src/app/shared/component/info-icon.component.html | 3 ++- ui/src/app/shared/component/info-icon.component.scss | 6 ++---- ui/src/app/shared/component/info-icon.component.ts | 3 ++- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/ui/src/app/metadata/resolver/container/resolver-wizard.component.html b/ui/src/app/metadata/resolver/container/resolver-wizard.component.html index 1163fe889..b9a6a75d7 100644 --- a/ui/src/app/metadata/resolver/container/resolver-wizard.component.html +++ b/ui/src/app/metadata/resolver/container/resolver-wizard.component.html @@ -1,10 +1,12 @@
- +
+ +
- \ No newline at end of file + diff --git a/ui/src/app/shared/component/info-icon.component.html b/ui/src/app/shared/component/info-icon.component.html index 38dee05bd..f73d5e0eb 100644 --- a/ui/src/app/shared/component/info-icon.component.html +++ b/ui/src/app/shared/component/info-icon.component.html @@ -8,7 +8,8 @@ [triggers]="triggers" [placement]="placement" [attr.aria-flowto]="id" - role="tooltip"> + role="tooltip" + container="body"> diff --git a/ui/src/app/shared/component/info-icon.component.scss b/ui/src/app/shared/component/info-icon.component.scss index e42aa999e..87b013155 100644 --- a/ui/src/app/shared/component/info-icon.component.scss +++ b/ui/src/app/shared/component/info-icon.component.scss @@ -6,8 +6,6 @@ border: none; display: inline; } +} + - .popover .popover-body { - min-width: 160px; - } -} \ No newline at end of file diff --git a/ui/src/app/shared/component/info-icon.component.ts b/ui/src/app/shared/component/info-icon.component.ts index 5c340b410..84ac09d0a 100644 --- a/ui/src/app/shared/component/info-icon.component.ts +++ b/ui/src/app/shared/component/info-icon.component.ts @@ -12,7 +12,8 @@ export class InfoIconComponent { id: string = String.fromCharCode(65 + Math.floor(Math.random() * 26)) + Date.now().toString(); - triggers = 'mouseenter:mouseleave focus:blur'; + // triggers = 'mouseenter:mouseleave focus:blur'; + triggers = 'click'; container = 'body'; placement = ['top']; From ab6edcf592d57b4c574f022bc641ec72cb153718 Mon Sep 17 00:00:00 2001 From: Bill Smith Date: Mon, 26 Nov 2018 16:39:49 -0700 Subject: [PATCH 2/2] NOJIRA The lucene index was being cleared and recreated, but never committed. Added an indexWriter.commit back in. --- .../resolvers/opensaml/OpenSamlMetadataResolverDelegate.java | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/domain/resolvers/opensaml/OpenSamlMetadataResolverDelegate.java b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/domain/resolvers/opensaml/OpenSamlMetadataResolverDelegate.java index 7c26adc4d..a30610415 100644 --- a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/domain/resolvers/opensaml/OpenSamlMetadataResolverDelegate.java +++ b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/domain/resolvers/opensaml/OpenSamlMetadataResolverDelegate.java @@ -38,6 +38,7 @@ void addIndexedDescriptorsFromBackingStore(AbstractMetadataResolver.EntityBackin document.add(new StringField("tag", resourceId, Field.Store.YES)); indexWriter.addDocument(document); } + indexWriter.commit(); } catch (IOException e) { logger.error(e.getMessage(), e); throw new ComponentInitializationException(e);