From 757d2b8d2c8d8d5309af0d8b1c89a7d900ee5cbd Mon Sep 17 00:00:00 2001 From: Ryan Mathis Date: Tue, 16 Jul 2019 10:08:57 -0700 Subject: [PATCH] SHIBUI-1270 Fixed a11y issue --- .../configuration/effect/compare.effect.ts | 2 +- ui/src/theme/breadcrumb.scss | 15 ++------------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/ui/src/app/metadata/configuration/effect/compare.effect.ts b/ui/src/app/metadata/configuration/effect/compare.effect.ts index 1b3b4d633..bb6e077d2 100644 --- a/ui/src/app/metadata/configuration/effect/compare.effect.ts +++ b/ui/src/app/metadata/configuration/effect/compare.effect.ts @@ -20,7 +20,7 @@ export class CompareVersionEffects { compareVersionRequest$ = this.actions$.pipe( ofType(CompareActionTypes.COMPARE_METADATA_REQUEST), map(action => action.payload), - combineLatest( + withLatestFrom( this.store.select(getConfigurationModel) ), switchMap(([versions, model]) => { diff --git a/ui/src/theme/breadcrumb.scss b/ui/src/theme/breadcrumb.scss index f1e5a6c93..9482c7233 100644 --- a/ui/src/theme/breadcrumb.scss +++ b/ui/src/theme/breadcrumb.scss @@ -1,5 +1,5 @@ .breadcrumb-bar { - $default-color: $gray-400; + $default-color: $gray-700; padding: 0; margin: 1rem 0; @@ -7,18 +7,7 @@ border-radius: 0; padding: 0.375rem 0; border-bottom: 1px solid $gray-600; - /* - &, & > .breadcrumb-item.active { + & > .breadcrumb-item.active { color: $default-color; } - > .breadcrumb-item > a { - color: $white; - } - - & > .breadcrumb-item + .breadcrumb-item { - &::before { - color: $default-color; - } - } - */ } \ No newline at end of file