From 7f22af2e7c2a6425fa6b389a13f9dba49b88fa65 Mon Sep 17 00:00:00 2001 From: Ryan Mathis Date: Tue, 28 Sep 2021 11:51:11 -0700 Subject: [PATCH] Fixed null issue on source definition --- .../metadata/domain/source/definition/SourceDefinition.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/src/app/metadata/domain/source/definition/SourceDefinition.js b/ui/src/app/metadata/domain/source/definition/SourceDefinition.js index 310674fd1..6e2abdee3 100644 --- a/ui/src/app/metadata/domain/source/definition/SourceDefinition.js +++ b/ui/src/app/metadata/domain/source/definition/SourceDefinition.js @@ -28,13 +28,11 @@ export const SourceBase = { return (formData, errors) => { - console.log(errors) - if (entityIds.indexOf(formData.entityId) > -1) { errors.entityId.addError('message.id-unique'); } - if (pattern && !pattern.test(formData.entityId)) { + if (pattern && !pattern?.test(formData.entityId)) { errors.entityId.addError(translator('message.group-pattern-fail', {regex: group?.validationRegex})); } @@ -44,7 +42,7 @@ export const SourceBase = { if (Array.isArray(formData?.assertionConsumerServices)) { formData.assertionConsumerServices.forEach((acs, idx) => { - if (!isNil(acs?.locationUrl) && !pattern.test(acs.locationUrl)) { + if (pattern && !isNil(acs?.locationUrl) && !pattern?.test(acs.locationUrl)) { errors.assertionConsumerServices[idx].locationUrl.addError(translator('message.group-pattern-fail', { regex: group?.validationRegex })) } });