From 8c4945d377b47d2d620bef81a397b71fd9d71fe9 Mon Sep 17 00:00:00 2001 From: Dmitriy Kopylenko Date: Thu, 16 Aug 2018 15:19:38 -0400 Subject: [PATCH] Add TODO note about manipulating filters directly via FilterRepository --- .../admin/ui/controller/MetadataFiltersController.java | 1 + 1 file changed, 1 insertion(+) diff --git a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java index 605f948a9..2ec5f01ab 100644 --- a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java +++ b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java @@ -130,6 +130,7 @@ public ResponseEntity delete(@PathVariable String metadataResolverId, @PathVariable String resourceId) { MetadataResolver resolver = findResolverOrThrowHttp404(metadataResolverId); + //TODO: consider implementing delete of filter directly from RDBMS via FilterRepository boolean removed = resolver.getMetadataFilters().removeIf(f -> f.getResourceId().equals(resourceId)); if(!removed) { throw HTTP_404_CLIENT_ERROR_EXCEPTION.get();