From d6ff6ddbbad6dcdc9e8856a630dc896f9e441322 Mon Sep 17 00:00:00 2001 From: Bill Smith Date: Thu, 24 Jan 2019 14:57:56 -0700 Subject: [PATCH] [SHIBUI-1029] Added a filter to remove admins that have no email addressees from the new user email sending. --- .../tier/shibboleth/admin/ui/service/EmailServiceImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/EmailServiceImpl.java b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/EmailServiceImpl.java index 6e8d20f28..e21051abd 100644 --- a/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/EmailServiceImpl.java +++ b/backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/service/EmailServiceImpl.java @@ -2,6 +2,7 @@ import edu.internet2.tier.shibboleth.admin.ui.security.model.User; import edu.internet2.tier.shibboleth.admin.ui.security.repository.UserRepository; +import org.apache.commons.lang.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.context.support.ResourceBundleMessageSource; @@ -72,6 +73,6 @@ public String[] getSystemAdminEmailAddresses() { logger.warn("No users with ROLE_ADMIN were found! Check your configuration!"); systemAdmins = new HashSet<>(); } - return systemAdmins.stream().map(User::getEmailAddress).distinct().toArray(String[]::new); + return systemAdmins.stream().filter(user -> StringUtils.isNotBlank(user.getEmailAddress())).map(User::getEmailAddress).distinct().toArray(String[]::new); } }