From 4ad87e1a89259ffee2a9e3a4a02ac5eace8fbe84 Mon Sep 17 00:00:00 2001
From: Yoann Chaudet <yoannchaudet@github.com>
Date: Wed, 28 Dec 2022 09:25:45 -0800
Subject: [PATCH 1/3] nit
---
entrypoint.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/entrypoint.sh b/entrypoint.sh
index bb396ea..344ec24 100755
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -1,10 +1,10 @@
#!/bin/bash
-#######################################################################################################
+####################################################################################################
#
-# Calls github-pages executable to build the site using whitelisted plugins and supported configuration
+# Calls github-pages executable to build the site using allowed plugins and supported configuration
#
-#######################################################################################################
+####################################################################################################
set -o errexit
From a32bfc58764808ea7b5e86530e7064be52a36226 Mon Sep 17 00:00:00 2001
From: Yoann Chaudet <yoannchaudet@github.com>
Date: Wed, 28 Dec 2022 09:32:42 -0800
Subject: [PATCH 2/3] fix shellcheck workflow
---
.github/workflows/shellcheck.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml
index 2964c7c..bee3c87 100644
--- a/.github/workflows/shellcheck.yml
+++ b/.github/workflows/shellcheck.yml
@@ -4,6 +4,8 @@ on:
pull_request:
paths:
- '**.sh'
+ # this is too wide but will cover shell scripts without an extension in that folder
+ - 'bin/*'
jobs:
shellcheck:
From 7476e98f2bca2879197404137da61ca763b77640 Mon Sep 17 00:00:00 2001
From: Yoann Chaudet <yoannchaudet@github.com>
Date: Wed, 28 Dec 2022 09:35:14 -0800
Subject: [PATCH 3/3] fix linter issues
---
bin/record_expected_output | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/record_expected_output b/bin/record_expected_output
index 8d88bdc..54b3d9a 100755
--- a/bin/record_expected_output
+++ b/bin/record_expected_output
@@ -5,9 +5,9 @@ if [ "local" = "$1" ]; then
export PAGES_REPO_NWO=actions/jekyll-build-pages
export JEKYLL_BUILD_REVISION=JEKYLL_BUILD_REVISION
- for dir in $(ls test_projects)
+ for dir in test_projects/*
do
- bundle exec github-pages build --verbose -s test_projects/$dir -d test_projects/$dir/_expected
+ bundle exec github-pages build --verbose -s "test_projects/${dir}" -d "test_projects/${dir}/_expected"
done
else
act -b -s GITHUB_TOKEN -j record-expected-output