GSH_JVMARGS not taken from environment

[ghost]

On line 7 in the gsh wrapper, the export command for GSH_JVMARGS doesn't include any existing value from that environment variable. Even if we set GSH_JVMARGS in the Dockerfile, the value is overwritten when this script executes. Perhaps adding ${GSH_JVMARGS} to the export command would help. This was also noticed in line 7 of the daemon wrapper.

[ghost]

Hi @kwessel,

Are you talking about the gsh file in /usr/local/bin or the gsh file in /opt/grouper/grouper.api/bin?

[ghost]

I guess I should add. I think this is a @chyzer issue as the files in /usr/grouper/grouper.api/bin are "his" files.

[ghost]

No, this isn't the Grouper native scripts, this is the TIER Grouper wrappers in /usr/local/bin. We tried to associate this issue specifically with /usr/local/bin/daemon and /usr/local/bin/gsh, but I guess that didn't work. It should be a trivial change to those two wrapper scripts, though.

[ghost]

Oh, gotcha. Sorry I completely forgot that I has set that variable to enable logging. I've included a self-reference to the variable when setting it in the gsh and daemon scripts. It's being built into master now. It'll get pulled into the next patch-base tag when the Grouper releases the next set of patches. (Unless you'd like us to pull the change into an older tag... let me know which if so.)

[ghost]

The master builds is complete. Please give it a test and confirm that it meets your needs. Or if you need me to apply the change to a specific grouper patch set.