From 34c941dc31c846e4be3b30287d099b6ad98d047f Mon Sep 17 00:00:00 2001 From: Alex Kalyvitis Date: Fri, 19 Jun 2020 13:27:45 +0200 Subject: [PATCH] Use Object.entries() instead of checking hasOwnProperty Co-authored-by: Robert --- src/setup-tools.test.ts | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/setup-tools.test.ts b/src/setup-tools.test.ts index 7cf565142..96680b339 100644 --- a/src/setup-tools.test.ts +++ b/src/setup-tools.test.ts @@ -49,18 +49,14 @@ test('parse codeql bundle url version', t => { '1.2.3-beta.1': '1.2.3-beta.1', }; - for (const version in tests) { - if (tests.hasOwnProperty(version)) { - - const expectedVersion = tests[version]; - const url = `https://github.com/.../codeql-bundle-${version}/...`; - - try { - const parsedVersion = setupTools.getCodeQLURLVersion(url); - t.deepEqual(parsedVersion, expectedVersion); - } catch (e) { - t.fail(e.message); - } + for (const [version, expectedVersion] of Object.entries(tests)) { + const url = `https://github.com/.../codeql-bundle-${version}/...`; + + try { + const parsedVersion = setupTools.getCodeQLURLVersion(url); + t.deepEqual(parsedVersion, expectedVersion); + } catch (e) { + t.fail(e.message); } } });