From 51e71f81a045f4ef5dcd6d2c2493ecd3cb24f2a9 Mon Sep 17 00:00:00 2001 From: "Fotis Koutoulakis (@NlightNFotis)" Date: Mon, 9 Dec 2024 18:59:37 +0000 Subject: [PATCH] docs: add documentation for the reason why we need to have a setup step for the container --- .github/workflows/__test-proxy.yml | 3 +++ pr-checks/checks/test-proxy.yml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/__test-proxy.yml b/.github/workflows/__test-proxy.yml index b6e1a0814..d2ffe1f6b 100644 --- a/.github/workflows/__test-proxy.yml +++ b/.github/workflows/__test-proxy.yml @@ -38,6 +38,9 @@ jobs: timeout-minutes: 45 runs-on: ${{ matrix.os }} steps: + # These steps are required to initialise the `gh` cli in a container that doesn't + # come pre-installed with it. The reason for that is that this is later + # needed by the `prepare-test` workflow to find the latest release of CodeQL. - name: Set up GitHub CLI run: | apt update diff --git a/pr-checks/checks/test-proxy.yml b/pr-checks/checks/test-proxy.yml index 9560ec4bc..39efb214e 100644 --- a/pr-checks/checks/test-proxy.yml +++ b/pr-checks/checks/test-proxy.yml @@ -5,6 +5,9 @@ operatingSystems: ["ubuntu"] container: image: ubuntu:22.04 container-init-steps: + # These steps are required to initialise the `gh` cli in a container that doesn't + # come pre-installed with it. The reason for that is that this is later + # needed by the `prepare-test` workflow to find the latest release of CodeQL. name: Set up GitHub CLI run: | apt update