From 570734c55cf1311f85574586c6a07b27dcc2c8fe Mon Sep 17 00:00:00 2001 From: Angela P Wen Date: Wed, 24 May 2023 11:33:06 -0700 Subject: [PATCH] Remove unnecessary conditional for Ruby autodetect (#1699) We should check language autodetect for Ruby unconditionally. We can now move it into the step that checks all other languages. --- .github/workflows/__multi-language-autodetect.yml | 7 +------ pr-checks/checks/multi-language-autodetect.yml | 7 +------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/.github/workflows/__multi-language-autodetect.yml b/.github/workflows/__multi-language-autodetect.yml index 02f3372fe..837d2547a 100644 --- a/.github/workflows/__multi-language-autodetect.yml +++ b/.github/workflows/__multi-language-autodetect.yml @@ -93,7 +93,7 @@ jobs: with: upload-database: false - - name: Check language autodetect for all languages excluding Ruby, Swift + - name: Check language autodetect for all languages excluding Swift shell: bash run: | CPP_DB=${{ fromJson(steps.analysis.outputs.db-locations).cpp }} @@ -126,11 +126,6 @@ jobs: echo "Did not create a database for Python, or created it in the wrong location." exit 1 fi - - - name: Check language autodetect for Ruby - if: env.CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT == 'true' - shell: bash - run: | RUBY_DB=${{ fromJson(steps.analysis.outputs.db-locations).ruby }} if [[ ! -d $RUBY_DB ]] || [[ ! $RUBY_DB == ${{ runner.temp }}/customDbLocation/* ]]; then echo "Did not create a database for Ruby, or created it in the wrong location." diff --git a/pr-checks/checks/multi-language-autodetect.yml b/pr-checks/checks/multi-language-autodetect.yml index 1fa3c42e2..7954de7e9 100644 --- a/pr-checks/checks/multi-language-autodetect.yml +++ b/pr-checks/checks/multi-language-autodetect.yml @@ -21,7 +21,7 @@ steps: with: upload-database: false - - name: Check language autodetect for all languages excluding Ruby, Swift + - name: Check language autodetect for all languages excluding Swift shell: bash run: | CPP_DB=${{ fromJson(steps.analysis.outputs.db-locations).cpp }} @@ -54,11 +54,6 @@ steps: echo "Did not create a database for Python, or created it in the wrong location." exit 1 fi - - - name: Check language autodetect for Ruby - if: env.CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT == 'true' - shell: bash - run: | RUBY_DB=${{ fromJson(steps.analysis.outputs.db-locations).ruby }} if [[ ! -d $RUBY_DB ]] || [[ ! $RUBY_DB == ${{ runner.temp }}/customDbLocation/* ]]; then echo "Did not create a database for Ruby, or created it in the wrong location."