From 7c35b4f6b532751db53ff3fab0e00b16f7fa0179 Mon Sep 17 00:00:00 2001 From: Angela P Wen Date: Mon, 24 Jun 2024 16:33:10 +0200 Subject: [PATCH] Rename for clarity per PR review --- pr-checks/sync.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pr-checks/sync.py b/pr-checks/sync.py index 31e818cce..08520890b 100755 --- a/pr-checks/sync.py +++ b/pr-checks/sync.py @@ -27,7 +27,7 @@ "nightly-latest" ] -def is_version_and_os_excluded(version, os, exclude_params): +def is_os_and_version_excluded(version, os, exclude_params): for exclude_param in exclude_params: if exclude_param[0] == os and exclude_param[1] == version: return True @@ -63,7 +63,7 @@ def writeHeader(checkStream): with open(file, 'r') as checkStream: checkSpecification = yaml.load(checkStream) matrix = [] - excludedVersionsAndOses = checkSpecification.get('excludeOsAndVersionCombination', []) + excludedOsesAndVersions = checkSpecification.get('excludeOsAndVersionCombination', []) for version in checkSpecification.get('versions', defaultTestVersions): runnerImages = ["ubuntu-latest", "macos-latest", "windows-latest"] operatingSystems = checkSpecification.get('operatingSystems', ["ubuntu", "macos", "windows"]) @@ -73,7 +73,7 @@ def writeHeader(checkStream): for runnerImage in runnerImagesForOs: # Skip appending this combination to the matrix if it is explicitly excluded. - if is_version_and_os_excluded(version, operatingSystem, excludedVersionsAndOses): + if is_os_and_version_excluded(version, operatingSystem, excludedOsesAndVersions): continue # Prior to CLI v2.15.1, ARM runners were not supported by the build tracer.