From beac9d56213438438d51928435fc2e0bfd1cacfe Mon Sep 17 00:00:00 2001 From: Chris Gavin Date: Tue, 3 Nov 2020 13:57:41 +0000 Subject: [PATCH 1/2] Fix a copy and pasted job name. --- .../workflows/update-supported-enterprise-server-versions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-supported-enterprise-server-versions.yml b/.github/workflows/update-supported-enterprise-server-versions.yml index 367f5172b..bc36e9ee9 100644 --- a/.github/workflows/update-supported-enterprise-server-versions.yml +++ b/.github/workflows/update-supported-enterprise-server-versions.yml @@ -5,7 +5,7 @@ on: - cron: "0 0 * * *" jobs: - multi-language-repo_test-autodetect-languages: + update-supported-enterprise-server-versions: runs-on: ubuntu-latest steps: From 4ffed2603ebbdc44261593d16cf6254747c6f07a Mon Sep 17 00:00:00 2001 From: Chris Gavin Date: Tue, 3 Nov 2020 13:58:07 +0000 Subject: [PATCH 2/2] Only increase the newest supported release, never reduce it. --- .../update-supported-enterprise-server-versions/update.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update-supported-enterprise-server-versions/update.py b/.github/workflows/update-supported-enterprise-server-versions/update.py index 7fa5edf44..50460256e 100755 --- a/.github/workflows/update-supported-enterprise-server-versions/update.py +++ b/.github/workflows/update-supported-enterprise-server-versions/update.py @@ -12,16 +12,18 @@ _FIRST_SUPPORTED_RELEASE = semver.VersionInfo.parse("2.22.0") # Versions older than this did not include Code Scanning. def main(): + api_compatibility_data = json.loads(_API_COMPATIBILITY_PATH.read_text()) + releases = json.loads(_RELEASE_FILE_PATH.read_text()) oldest_supported_release = None - newest_supported_release = None + newest_supported_release = semver.VersionInfo.parse(api_compatibility_data["maximumVersion"] + ".0") for release_version_string, release_data in releases.items(): release_version = semver.VersionInfo.parse(release_version_string + ".0") if release_version < _FIRST_SUPPORTED_RELEASE: continue - if newest_supported_release is None or release_version > newest_supported_release: + if release_version > newest_supported_release: feature_freeze_date = datetime.date.fromisoformat(release_data["feature_freeze"]) if feature_freeze_date < datetime.date.today() + datetime.timedelta(weeks=2): newest_supported_release = release_version