From d5ad81bcd497cf076617ea812d968560867fe732 Mon Sep 17 00:00:00 2001 From: Henry Mercer Date: Tue, 23 Aug 2022 18:00:22 +0100 Subject: [PATCH] Fix Go custom tracing tests These were supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than CODEQL_EXTRACTOR_GO_BUILD_TRACING=on, therefore tracing wasn't being tested. --- .github/workflows/__go-custom-tracing-autobuild.yml | 2 +- .github/workflows/__go-custom-tracing.yml | 2 +- pr-checks/checks/go-custom-tracing-autobuild.yml | 2 +- pr-checks/checks/go-custom-tracing.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/__go-custom-tracing-autobuild.yml b/.github/workflows/__go-custom-tracing-autobuild.yml index a2c6208df..a2ede1b92 100644 --- a/.github/workflows/__go-custom-tracing-autobuild.yml +++ b/.github/workflows/__go-custom-tracing-autobuild.yml @@ -81,5 +81,5 @@ jobs: exit 1 fi env: - CODEQL_EXTRACTOR_GO_BUILD_TRACING: 'true' + CODEQL_EXTRACTOR_GO_BUILD_TRACING: on INTERNAL_CODEQL_ACTION_DEBUG_LOC: true diff --git a/.github/workflows/__go-custom-tracing.yml b/.github/workflows/__go-custom-tracing.yml index 88e571e67..74ed3fb88 100644 --- a/.github/workflows/__go-custom-tracing.yml +++ b/.github/workflows/__go-custom-tracing.yml @@ -92,5 +92,5 @@ jobs: env: TEST_MODE: true env: - CODEQL_EXTRACTOR_GO_BUILD_TRACING: 'true' + CODEQL_EXTRACTOR_GO_BUILD_TRACING: on INTERNAL_CODEQL_ACTION_DEBUG_LOC: true diff --git a/pr-checks/checks/go-custom-tracing-autobuild.yml b/pr-checks/checks/go-custom-tracing-autobuild.yml index 4a298e0ee..3414313ac 100644 --- a/pr-checks/checks/go-custom-tracing-autobuild.yml +++ b/pr-checks/checks/go-custom-tracing-autobuild.yml @@ -2,7 +2,7 @@ name: "Go: Autobuild custom tracing" description: "Checks that Go tracing works in conjunction with the autobuilder" os: ["ubuntu-latest", "macos-latest"] env: - CODEQL_EXTRACTOR_GO_BUILD_TRACING: "true" + CODEQL_EXTRACTOR_GO_BUILD_TRACING: "on" steps: - uses: actions/setup-go@v3 with: diff --git a/pr-checks/checks/go-custom-tracing.yml b/pr-checks/checks/go-custom-tracing.yml index 3bce0e282..e80594dda 100644 --- a/pr-checks/checks/go-custom-tracing.yml +++ b/pr-checks/checks/go-custom-tracing.yml @@ -1,7 +1,7 @@ name: "Go: Custom tracing" description: "Checks that Go tracing works" env: - CODEQL_EXTRACTOR_GO_BUILD_TRACING: "true" + CODEQL_EXTRACTOR_GO_BUILD_TRACING: "on" steps: - uses: actions/setup-go@v3 with: