From e5fdcd4a8fbfda0ca8c65d32c013969ad181991d Mon Sep 17 00:00:00 2001 From: Shaikhul Islam Date: Thu, 11 May 2023 09:29:25 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Henry Mercer --- CHANGELOG.md | 2 +- src/workflow.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b36c3cddd..7e876fdd6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ No user facing changes. ## 2.3.4 - 10 May 2023 -- Remove some checks from code scanning workflow validation. [#1675](https://github.com/github/codeql-action/pull/1675) +- Remove the requirement for `on.push` and `on.pull_request` to trigger on the same branches. [#1675](https://github.com/github/codeql-action/pull/1675) ## 2.3.3 - 04 May 2023 diff --git a/src/workflow.ts b/src/workflow.ts index c5e9bd785..0d932cbb0 100644 --- a/src/workflow.ts +++ b/src/workflow.ts @@ -96,7 +96,7 @@ function toCodedErrors(errors: { // code to send back via status report // message to add as a warning annotation to the run export const WorkflowErrors = toCodedErrors({ - MissingPushHook: `Please specify an on.push hook.`, + MissingPushHook: `Please specify an on.push hook to analyze and see code scanning alerts from the default branch on the Security tab.`, CheckoutWrongHead: `git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.`, });