From b661ef1697d555e1f2ab5c42d3c60b5bb71b6cf2 Mon Sep 17 00:00:00 2001 From: Chris Gavin Date: Thu, 9 Dec 2021 10:21:34 +0000 Subject: [PATCH 1/2] Start waiting for processing by default. --- CHANGELOG.md | 1 + analyze/action.yml | 2 +- upload-sarif/action.yml | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 33954b221..1ca7a2f84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## [UNRELEASED] - Update default CodeQL bundle version to 2.7.3. [#842](https://github.com/github/codeql-action/pull/842) +- The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`. ## 1.0.25 - 06 Dec 2021 diff --git a/analyze/action.yml b/analyze/action.yml index 50c8b3d31..104311272 100644 --- a/analyze/action.yml +++ b/analyze/action.yml @@ -55,7 +55,7 @@ inputs: wait-for-processing: description: If true, the Action will wait for the uploaded SARIF to be processed before completing. required: true - default: "false" + default: "true" token: default: ${{ github.token }} matrix: diff --git a/upload-sarif/action.yml b/upload-sarif/action.yml index 3f26f099b..ee87c6ec1 100644 --- a/upload-sarif/action.yml +++ b/upload-sarif/action.yml @@ -23,7 +23,7 @@ inputs: wait-for-processing: description: If true, the Action will wait for the uploaded SARIF to be processed before completing. required: true - default: "false" + default: "true" runs: using: 'node12' main: '../lib/upload-sarif-action.js' From 7bcc6564d4e06eb266a88a56c4a577423bfcd6d0 Mon Sep 17 00:00:00 2001 From: Chris Gavin Date: Thu, 9 Dec 2021 12:53:20 +0000 Subject: [PATCH 2/2] Add more context to a change note. Co-authored-by: Thomas Horstmeyer <73262256+cannist@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ca7a2f84..b012c6c96 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ## [UNRELEASED] - Update default CodeQL bundle version to 2.7.3. [#842](https://github.com/github/codeql-action/pull/842) -- The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`. +- The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`. ## 1.0.25 - 06 Dec 2021