From a3d7673b3034efe762c60f9b1930fe7ba6ed5011 Mon Sep 17 00:00:00 2001 From: Landon Grindheim Date: Thu, 5 May 2022 14:42:33 +0000 Subject: [PATCH] Prefer verbose `npm` command as bread crumb Likely due to ignorance of the npm ecosystem, I found myself thinking that `npm ci` was perhaps a directive to execute a **C**ontinuous **I**ntegration workflow, rather than doing a clean install. Updating these references in case any future developers share my ignorance. --- .github/workflows/check-dist.yml | 2 +- .github/workflows/dependabot-build.yml | 2 +- .github/workflows/integration-test.yml | 2 +- .github/workflows/test.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml index 8fb3d45..802610a 100644 --- a/.github/workflows/check-dist.yml +++ b/.github/workflows/check-dist.yml @@ -26,7 +26,7 @@ jobs: node-version: ${{ steps.nvm.outputs.NVMRC }} - name: Install npm dependencies - run: npm ci + run: npm clean-install - name: Rebuild the dist/ directory run: npm run package diff --git a/.github/workflows/dependabot-build.yml b/.github/workflows/dependabot-build.yml index e688388..f03b6cb 100644 --- a/.github/workflows/dependabot-build.yml +++ b/.github/workflows/dependabot-build.yml @@ -45,7 +45,7 @@ jobs: node-version: ${{ steps.nvm.outputs.NVMRC }} - name: Install npm dependencies - run: npm ci + run: npm clean-install # If we're reacting to a Docker PR, we have on extra step to refresh and check in the container manifest, # this **must** happen before rebuilding dist/ so it uses the new version of the manifest diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml index 905b116..e9c6faf 100644 --- a/.github/workflows/integration-test.yml +++ b/.github/workflows/integration-test.yml @@ -27,7 +27,7 @@ jobs: node-version: ${{ steps.nvm.outputs.NVMRC }} - name: Install npm dependencies - run: npm ci + run: npm clean-install - name: Pre-fetch the pinned images run: npm run fetch-images diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 762eb01..9a7b3d2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,7 +25,7 @@ jobs: node-version: ${{ steps.nvm.outputs.NVMRC }} - name: Install npm dependencies - run: npm ci + run: npm clean-install - name: Check formatting run: npm run format-check