From 9eaa7f024f8f7a927925ad6fd74f641904bbeeba Mon Sep 17 00:00:00 2001 From: Pavol Mederly Date: Sat, 23 Nov 2019 10:20:52 +0100 Subject: [PATCH] General cleanup of connector code Obsolete features like support for __ACCOUNT__ and __GROUP__ object classes were removed. Currently the connector supports only PlainGroup object class that contains a list of group members. The code was generally cleaned up and refactored to improve understandability and maintainability. Unnecessary dependencies were removed to reduce JAR size. Version was increased to 0.5. --- README.md | 15 +- pom.xml | 37 +- src/main/assembly/connector.xml | 2 +- .../grouper/rest/AbstractGroupProcessor.java | 201 -------- .../grouper/rest/AccountProcessor.java | 173 ------- .../grouper/rest/GroupProcessor.java | 302 ++++++++++++ .../grouper/rest/GrouperConfiguration.java | 409 +++++++-------- .../grouper/rest/GrouperConnector.java | 196 ++++---- .../grouper/rest/PlainGroupProcessor.java | 184 ------- .../connector/grouper/rest/Processor.java | 464 ++++++------------ .../grouper/rest/StandardGroupProcessor.java | 68 --- .../grouper/rest/Messages.properties | 47 +- .../connector/grouper/test/AbstractTest.java | 80 +++ .../connector/grouper/test/AccountTests.java | 79 --- .../{PlainGroupTests.java => GroupTest.java} | 103 ++-- .../grouper/test/GrouperTestHelper.java | 102 ---- .../grouper/test/StandardGroupTests.java | 95 ---- 17 files changed, 934 insertions(+), 1623 deletions(-) delete mode 100644 src/main/java/com/evolveum/polygon/connector/grouper/rest/AbstractGroupProcessor.java delete mode 100644 src/main/java/com/evolveum/polygon/connector/grouper/rest/AccountProcessor.java create mode 100644 src/main/java/com/evolveum/polygon/connector/grouper/rest/GroupProcessor.java delete mode 100644 src/main/java/com/evolveum/polygon/connector/grouper/rest/PlainGroupProcessor.java delete mode 100644 src/main/java/com/evolveum/polygon/connector/grouper/rest/StandardGroupProcessor.java create mode 100644 src/test/java/com/evolveum/polygon/connector/grouper/test/AbstractTest.java delete mode 100644 src/test/java/com/evolveum/polygon/connector/grouper/test/AccountTests.java rename src/test/java/com/evolveum/polygon/connector/grouper/test/{PlainGroupTests.java => GroupTest.java} (57%) delete mode 100644 src/test/java/com/evolveum/polygon/connector/grouper/test/GrouperTestHelper.java delete mode 100644 src/test/java/com/evolveum/polygon/connector/grouper/test/StandardGroupTests.java diff --git a/README.md b/README.md index f1df27d..53d0b11 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,15 @@ # midPoint-Grouper_connector -Two connectors to be maintained: a REST connector and the Groovy scripts for an AMQP "connector" +This is a connector that can read groups from a Grouper instance using REST calls. +Currently it supports these searches only: +- fetching all groups, +- fetching a group by name, +- fetching a group by UUID. + +When fetching a group, a client can choose whether to get basic group data only (name, UUID, extension) or whether +to obtain a list of group members as well. + +Besides `search` operation the following ones are supported: +- `schema` +- `test` + +This connector was tested with Grouper 2.4. \ No newline at end of file diff --git a/pom.xml b/pom.xml index 9916a84..8baa810 100644 --- a/pom.xml +++ b/pom.xml @@ -23,11 +23,11 @@ connector-parent com.evolveum.polygon 1.4.2.14 - + connector-grouper-rest - 0.4 + 0.5 jar Grouper REST Connector @@ -35,6 +35,7 @@ com.evolveum.polygon.connector.grouper.rest GrouperRestConnector + 1.8 @@ -84,7 +85,6 @@ com.evolveum.polygon 1.4.2.14-SNAPSHOT - org.apache.httpcomponents httpclient @@ -101,36 +101,5 @@ 6.8 test - - - batik - batik-swing - 1.6 - - - batik - batik-rasterizer - 1.6 - - - xml-apis - xml-apis - 1.3.04 - - - xml-apis - xml-apis-ext - 1.3.04 - - - diff --git a/src/main/assembly/connector.xml b/src/main/assembly/connector.xml index efca6d1..6d149b4 100644 --- a/src/main/assembly/connector.xml +++ b/src/main/assembly/connector.xml @@ -1,6 +1,6 @@