From 7bb06c880ad0a25272e1656a54e0375d9d56f0d2 Mon Sep 17 00:00:00 2001 From: Duncan Brown Date: Wed, 9 Oct 2019 12:23:51 -0400 Subject: [PATCH 1/2] set missing environment variable --- docs/shibboleth-sp-mariadb.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/shibboleth-sp-mariadb.md b/docs/shibboleth-sp-mariadb.md index e4792e6..3c93624 100644 --- a/docs/shibboleth-sp-mariadb.md +++ b/docs/shibboleth-sp-mariadb.md @@ -85,6 +85,7 @@ to be the version of the image you are about to build: ``` export COMANAGE_REGISTRY_SHIBBOLETH_SP_IMAGE_VERSION=1 +export COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION=3.2.1 ``` * Build an image for COmanage Registry that uses the Shibboleth SP @@ -97,6 +98,7 @@ docker build \ --build-arg COMANAGE_REGISTRY_VERSION=${COMANAGE_REGISTRY_VERSION} \ --build-arg COMANAGE_REGISTRY_BASE_IMAGE_VERSION=${COMANAGE_REGISTRY_BASE_IMAGE_VERSION} \ --build-arg COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION=${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION} \ + --build-arg COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION=${COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION} \ -t comanage-registry:$TAG . popd ``` From 76761a1820a66990e679b6892667053e864f94ae Mon Sep 17 00:00:00 2001 From: Duncan Brown Date: Tue, 12 Nov 2019 14:00:20 -0500 Subject: [PATCH 2/2] fixed tag in documentation --- docs/shibboleth-sp-mariadb.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/shibboleth-sp-mariadb.md b/docs/shibboleth-sp-mariadb.md index 3c93624..980a465 100644 --- a/docs/shibboleth-sp-mariadb.md +++ b/docs/shibboleth-sp-mariadb.md @@ -74,7 +74,7 @@ export COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION=1 ``` pushd comanage-registry-shibboleth-sp-base -TAG="${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION}" +TAG=${COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION}-${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION} docker build \ -t comanage-registry-shibboleth-sp-base:$TAG . popd