Skip display of loading animation when CMD, CTRL, or SHIFT is pressed…

… (CO-2488) (#41)
COmanage · Sep 5, 2022 · 658df39 · 658df39
1 parent f02910b
commit 658df39
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/app/templates/element/javascript.php b/app/templates/element/javascript.php
@@ -178,13 +178,16 @@
 
     // Add loading animation when a form is submitted, when any item with a "spin" class is clicked, 
     // or on any button or anchor tag lacking the .nospin class.
-    $("input[type='submit'], button:not(.nospin), a:not(.nospin), .spin").click(function() {
+    $("input[type='submit'], button:not(.nospin), a:not(.nospin), .spin").click(function(e) {
 
-      displaySpinner();
+      // Start a spinner only if CTRL, CMD, or SHIFT is not pressed (which loads a new tab or window).
+      if(!(e.ctrlKey || e.metaKey || e.shiftKey)) {
+        displaySpinner();
 
-      // Test for invalid fields (HTML5) and turn off spinner explicitly if found
-      if(document.querySelectorAll(":invalid").length) {
-        stopSpinner();
+        // Test for invalid fields (HTML5) and turn off spinner explicitly if found
+        if (document.querySelectorAll(":invalid").length) {
+          stopSpinner();
+        }
       }
 
     });