Improve clickability for data rows (CO-1949)

COmanage · Jun 16, 2020 · 9e1113e · 9e1113e
1 parent 049ad5e
commit 9e1113e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/app/src/Template/Element/javascript.ctp b/app/src/Template/Element/javascript.ctp
@@ -201,8 +201,8 @@
       }
     });
 
-    // Generic table-row click handling
-    $('tr.linked-row').click(function (e) {
+    // Generic row click handling
+    $('.linked-row').click(function (e) {
        location.href = $(this).find('a.row-link').attr('href');
     });
 

diff --git a/app/src/Template/Matchgrids/select.ctp b/app/src/Template/Matchgrids/select.ctp
@@ -53,7 +53,7 @@ use \App\Lib\Enum\PermissionEnum;
       continue;
     }
   ?>
-  <div class="row co-row">
+  <div class="row co-row linked-row spin">
     <div class="collab-name col">
       <?= filter_var($name, FILTER_SANITIZE_SPECIAL_CHARS); ?>
     </div>
@@ -68,7 +68,7 @@ use \App\Lib\Enum\PermissionEnum;
                                   ['controller' => 'Matchgrids',
                                    'action'     => 'manage',
                                    $id],
-                                  ['class' => 'configurebutton']);
+                                  ['class' => 'configurebutton row-link']);
         }
       ?>
     </div>

diff --git a/app/webroot/css/co-base.css b/app/webroot/css/co-base.css
@@ -928,6 +928,9 @@ a.desc::before {
   background-color: #e5e5e5 !important;
   font-weight: bold;
 }
+.co-grid .co-row {
+  border-top: 1px solid #eee;
+}
 .co-grid .co-row:nth-child(even) {
   background-color: #f8f8f8;
 }
@@ -992,11 +995,12 @@ tr:nth-child(even) td {
 td.indented {
   border-left: 3em solid #fff;
 }
-tr.linked-row {
-  cursor: pointer;
+.linked-row {
+  cursor: pointer !important;
 }
-tr.linked-row:hover td {
-  background-color: #ffe;
+.linked-row:hover,
+.linked-row:hover td {
+  background-color: #ffd !important;
 }
 .menuitembutton {
   width: 250px;