Deprecate and remove jQuery UI (CO-2230) #17
Conversation
app/templates/layout/default.php
Outdated
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Why not put that into an element and just load it here?
There was a problem hiding this comment.
We certainly could. It's a static block though (so far as php is concerned). We're not instantiating it multiple times - so we don't gain much by putting it in an element.
There was a problem hiding this comment.
But it's a good idea :-)
| --cmg-color-gray-secondary: #555; | ||
| --cmg-color-gray-disabled: #666; | ||
| --cmg-color-white: #fff; | ||
| --cmg-color-black: #000; |
There was a problem hiding this comment.
why not use the same pattern for all the naming? For example you provide:
--cmg-color-gray-light-low and then there is
--cmg-color-infobox-yellow. Why not
--cmg-color-yellow-infobox?
In the future if we want to dynamically construct the variable names it would be very difficult unless they follow the same pattern.
For example: --cmg-color-<the_color>-<color_tone>-<color_tone_level>-<color_used>. So now what we should have for example is the following:
--cmg-color-yellow-light-low-infobox: #fbec88
--cmg-color-yellow-light-mid-warn: #fcc
There was a problem hiding this comment.
I was going to send you a note about these - the colors are very much a work in progress. We should talk about their naming scheme when we next meet - but I don't want that to hold up the ticket. I'm not entirely convinced we want to name their purpose in every instance for things like black, white, and gray - these are so ubiquitous in the css (borders, backgrounds, etc) that we'd end up being very verbose. I think there's probably a line where an element or collection of entities are important enough to name (links, banners, infoboxes, etc) that we do so - but possibly not for the simple pallettes? I may also be leaning towards stacking these in some of the ways we were considering. Let's talk it through. :-)
There was a problem hiding this comment.
We'll refactor these (can do after PR merge) into --cmg-color-color-tone-level with comments after each to describe how they are used. This approach keeps things simple and should help us avoid duplicating colors or being too verbose.
… as dropdowns by default for mobile. Dialog boxes converted to Bootstrap. (CO-2230)
|
The dialog box has been refactored into an element, and the code has been rebased against the latest develop. |
No description provided.