Skip to content

Fix up menus and information architecture to improve navigability. Fi… #2

Merged
merged 3 commits into from Sep 17, 2021

Conversation

@arlen
Copy link

@arlen arlen commented Sep 14, 2021

…rst pass refactoring of layout and CSS components to generalize and bring in line with Registry 4.0 and Registry Future. Remove unused libraries, and upgrade Bootstrap and jQuery. (CO-2141 / CO-1948 / CO-2133)

@@ -478,16 +478,40 @@ msgid "match.home.welcome"
msgstr "Welcome to {0}."

### Informational Messages
msgid "match.in.matchgrid"

This comment has been minimized.

@benno

benno Sep 16, 2021
Contributor

There's already a localization for matchgrid, Match.ct.Matchgrids, though see RTL comment below.

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

True - this should really be match.in.matchgrid.title and combined with the appropriate localization (sending the title to be combined with this). Will fix.

msgid "match.in.matchgrid"
msgstr "Matchgrid"

msgid "match.in.matchgrid.config"

This comment has been minimized.

@benno

benno Sep 16, 2021
Contributor

This feels more like match.op than match.in?

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

Probably so. I'll change it - it's used as a title on the Manage page ... as opposed to a button or link (which is why it ended up in the .in. section).

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

On second thought - It's not an operation - it's really just a title "Matchgrid Configuration" (not "Configure Matchgrid" ... I deliberated over noun vs. verb for this one). Both this item and "Matchgrid: name" serve the purpose of titles (headings, e.g. h1, h2), so I'll create a new section called match.ti for them.

msgid "match.me.display"
msgstr "Display"

msgid "match.me.manage"
msgstr "Manage"

msgid "match.me.platform"
msgstr "Platform"

msgid "match.me.reconcile"
Comment on lines 503 to 512

This comment has been minimized.

@benno

benno Sep 16, 2021
Contributor

Does this replace the match.op localizations?

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

These were not meant to replace them, but rather to separate the menus so they could be differentiated from buttons and links in the content areas. However, if that's over-complicated (and it is a little), I can use the match.op sections. I'll change these.

@@ -47,16 +47,6 @@ if($this->request->getRequestTarget(false) != '/') {
'action' => 'select']
);

if($modelsName != 'Matchgrids' && $modelsName != 'Permissions' && $modelsName != 'ApiUsers'
|| ($modelsName == 'Matchgrids' && ($action == 'reconcile' || $action == 'pending'))) {
// Link to matchgrids listing where appropriate

This comment has been minimized.

@benno

benno Sep 16, 2021
Contributor

Why does this go away?

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

My thinking is that the only way to get to the Platform-level Matchgrid listing (where we can edit or delete a Matchgrid) is from the Platform menu. When we're in the context of managing the matches, we want to only operate within the interior context of the matchgrid. So the breacrumbs will reflect getting to the matchgrid selector and then the matchgrid management page only. (The matchgrid select view should also not have the interstitial "Matchgrids" crumb, so I should weed that out.) I think the interstitial link to the platform level matchgrid page is otherwise a little confusing even for platform admins - because the grid selector list is the simple path to switch between the grids, and having both crumbs creates a situation where we have two adjacent links to extremely similar but slightly different information ... and in reality the activies and contexts of the pages are different. (One for moving between matchgrids, one for managing matchgrids themselves.)

(On a related note, I'd like to bounce users straight to the matchgrid management page on login if only one matchgrid exists, and we've discussed adding a quick selector to switch between matchgrids near the matchgrid management title, too. ...But both can wait.)

<?= $this->Html->link(__('match.meta.match'),'/'); ?>
<?php if(!empty($vv_cur_mg)): ?>
<?= $this->Html->link(
__('match.in.matchgrid') . ": " . $vv_cur_mg['table_name'],

This comment has been minimized.

@benno

benno Sep 16, 2021
Contributor

Infixing a colon violates RTL compatibility. Pass the table name as an argument to the localized text string instead.

This comment has been minimized.

@arlen

arlen Sep 17, 2021
Author

Absolutely right (oops!): I'll change this as suggested in the first comment.

@arlen
Copy link
Author

@arlen arlen commented Sep 17, 2021

I've updated the localization strings as described in the comments; I also hid the breadcrumbs from the "select matchgrid" page and made the hamburger menu only appear when it has a menu to interact with.

arlen added 3 commits Sep 14, 2021
…rst pass refactoring of layout and CSS components to generalize and bring in line with Registry 4.0 and Registry Future. Remove unused libraries, and upgrade Bootstrap and jQuery. (CO-2141 / CO-1948 / CO-2133)
@arlen arlen force-pushed the feature-co2141 branch from 4b6acf2 to 0b6cd7b Sep 17, 2021
@arlen
Copy link
Author

@arlen arlen commented Sep 17, 2021

This has been rebased against the latest develop.

@benno
benno approved these changes Sep 17, 2021
@benno benno merged commit 01ce3fb into develop Sep 17, 2021
@benno benno deleted the feature-co2141 branch Sep 17, 2021
Sign in to join this conversation on GitHub.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.