Refactor CSS colors (CO-2241) #23
Conversation
| * Colors use the convention --cmg-color-hue-number with optional comments to describe | ||
| * how they are used. "number" does not imply color value. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Hi @arlen i have a question.
The color file is fairly simple, and you’ll find the the numbers have no bearing on the color values
You mean that they do not imply ordering, from lighter to darker or vise versa. We should provide that information in the css file. It is not clear if a color with the postfix 001 is darker or lighter from the same one with the postfix 005.
We also have this comment:
"number" does not imply color value.
but it is not very self-explanatory, at least for me.
Perhaps we should add more text like what you provided in one of your comments:
use a numbering convention where 001 is whatever we think most important and then just add to it from there.
Bottom line, we might need one more line in the comment section that will better explain the numbering convention. Also, if we plan to have a wiki page, we should provide the link to the wiki page as well. Other than that, it looks great +1
There was a problem hiding this comment.
I've updated the description in the colors file - we may revisit this, but it's slightly improved. :-)
…g convention (CO-2241)
No description provided.