Add clickability to all data rows when a default action is obvious (CO-1949) #28
+43
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlen
changed the title
arlen
changed the title
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this PR allows us to generically add classes to any column in the index view (on both
<th>sand<td>s) by including cssClass as a parameter on the column.A "row-link" class on a linked column field will enable JavaScript to link an entire row to the URL found within the specified column's table cell. For example,
<td class="row-link"><a href="someplace">some field</a></td>will cause the row containing that cell to be clickable, linking to "someplace".Note that this is not enabled for the Matchgrid Records view (i.e. no column has the "row-link" class) because of usability issues when interacting with popovers.