Fixes required after Filtering feature initial commit

COmanage · May 1, 2022 · 08fa6ac · 08fa6ac
1 parent 9b995a6
commit 08fa6ac
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/app/src/Lib/Traits/SearchFilterTrait.php b/app/src/Lib/Traits/SearchFilterTrait.php
@@ -29,6 +29,8 @@
 
 namespace App\Lib\Traits;
 
+use Cake\Utility\Inflector;
+
 trait SearchFilterTrait {
   // Array (and configuration) of permitted search filters
   private $searchFilters = array();
@@ -54,9 +56,9 @@ public function getLabel(string $attribute): string {
     if($l != $attribute) {
       return $l;
     }
-    
-    // If we make it here, just return $attribute
-    return $attribute;
+
+    // If we make it here, just return a pretty version of the $attribute name
+    return Inflector::humanize($attribute);
   }
 
   /**

diff --git a/app/src/View/Helper/MenuHelper.php b/app/src/View/Helper/MenuHelper.php
@@ -80,7 +80,8 @@ public function getMenuIcon($action) {
       'Delete'        =>  'delete'
     );
 
-    return $icon[$action];
+    // For the actions with Default order we can pass directly the name of the icon
+    return $icon[$action] ?? $action;
   }
 
 }
diff --git a/app/templates/Standard/index.php b/app/templates/Standard/index.php
@@ -122,7 +122,7 @@ function _column_key($modelsName, $c, $tz=null) {
         }
 
         $action_args['vv_actions'][] = [
-          'order' => $this->Menu->getMenuOrder($t['icon']),
+          'order' => $this->Menu->getMenuOrder($t['order']),
           'icon' => $this->Menu->getMenuIcon($t['icon']),
           'url' => $this->Url->build($t['link']),
           'label' => $t['label'],