Various fixes to Clone Command (CO-479)

COmanage · Feb 8, 2026 · 0fdbe49 · 0fdbe49
1 parent eb0b042
commit 0fdbe49
Show file tree

Hide file tree

Showing 10 changed files with 368 additions and 124 deletions.
diff --git a/app/availableplugins/ApiConnector/config/plugin.json b/app/availableplugins/ApiConnector/config/plugin.json
@@ -40,7 +40,8 @@
           "api_source_records_i1": { "columns": [ "api_source_id" ] },
           "api_source_records_i2": { "columns": [ "api_source_id", "source_key" ] }
         },
-        "changelog": false
+        "changelog": false,
+        "clone_relation": true
       }
     }
   }

diff --git a/app/plugins/CoreServer/config/plugin.json b/app/plugins/CoreServer/config/plugin.json
@@ -47,8 +47,10 @@
           "required": {}
         },
         "indexes": {
-          "match_server_attributes_i1": { "columns": [ "match_server_id" ]}
-        }
+          "match_server_attributes_i1": { "columns": [ "match_server_id" ]},
+          "match_server_attributes_i2": { "needed": false, "columns": [ "type_id" ]}
+        },
+        "clone_relation": true
       },
       "oauth2_servers": {
         "columns": {
@@ -66,7 +68,8 @@
         },
         "indexes": {
           "oauth2_servers_i1": { "columns": [ "server_id" ] }
-        }
+        },
+        "clone_relation": true
       },
       "smtp_servers": {
         "columns": {
@@ -83,7 +86,8 @@
         },
         "indexes": {
           "smtp_servers_i1": { "columns": [ "server_id" ] }
-        }
+        },
+        "clone_relation": true
       },
       "sql_servers": {
         "columns": {
@@ -98,7 +102,8 @@
         },
         "indexes": {
           "sql_servers_i1": { "columns": [ "server_id" ]}
-        }
+        },
+        "clone_relation": true
       }
     }
   }

diff --git a/app/plugins/CoreServer/src/Model/Table/MatchServersTable.php b/app/plugins/CoreServer/src/Model/Table/MatchServersTable.php
@@ -328,7 +328,7 @@ protected function doRequest(
     }
 
     if($response->getStatusCode() != 200 && $response->getStatusCode() != 201) {
-      $error = $response->reasonPhrase;
+      $error = $response->getReasonPhrase();
 
       // If an error was provided in the response, use that instead
       if(!empty($body['error'])) {

diff --git a/app/plugins/EnvSource/config/plugin.json b/app/plugins/EnvSource/config/plugin.json
@@ -75,7 +75,8 @@
         "indexes": {
           "env_source_identities_i1": { "columns": [ "source_key" ] },
           "env_source_identities_i2": { "needed": false, "columns": [ "env_source_id" ] }
-        }
+        },
+        "clone_relation": true
       },
       "env_source_detours": {
         "columns": {