Refactor clonable fields for configuration-only approach (CFM-218)

COmanage · Nov 13, 2025 · 11829dd · 11829dd
1 parent 9bd9f99
commit 11829dd
Show file tree

Hide file tree

Showing 13 changed files with 41 additions and 23 deletions.
diff --git a/app/resources/locales/en_US/field.po b/app/resources/locales/en_US/field.po
@@ -68,6 +68,9 @@ msgstr "Revision"
 msgid "children"
 msgstr "Children"
 
+msgid "cloning"
+msgstr "Cloning"
+
 msgid "code"
 msgstr "Code"
 

diff --git a/app/templates/ApiUsers/fields.inc b/app/templates/ApiUsers/fields.inc
@@ -29,7 +29,6 @@ if($vv_cur_co->isCOmanageCO()) {
   $banners = [
     __d('information', 'api.cmp')
   ];
-  }
 }
 
 // We link to the "Generate" button on edit only
@@ -65,4 +64,4 @@ $fields = [
   'privileged', // boolean
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
diff --git a/app/templates/Cous/fields.inc b/app/templates/Cous/fields.inc
@@ -36,4 +36,4 @@ if(!empty($parents)) {
   ];
 }
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
diff --git a/app/templates/ExternalIdentitySources/fields.inc b/app/templates/ExternalIdentitySources/fields.inc
@@ -37,7 +37,7 @@ $fields = [
   'suppress_noop_logs'
 ];
 
-print $this->element('clonable');      
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));      
 
 // Top Links
 $topLinks = [

diff --git a/app/templates/Groups/fields.inc b/app/templates/Groups/fields.inc
@@ -72,7 +72,7 @@ if($vv_action != 'add') {
   }
 }
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
 
 // List the MVEAs that may be shown on the mveaCanvas
 // When this array exists, the mveaCanvas.php element will render  

diff --git a/app/templates/IdentifierAssignments/fields.inc b/app/templates/IdentifierAssignments/fields.inc
@@ -38,7 +38,7 @@ $fields = [
   'ordr'
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
 ?>
 
 <script>

diff --git a/app/templates/Pipelines/fields.inc b/app/templates/Pipelines/fields.inc
@@ -43,7 +43,7 @@ $fields = [
   // XXX Connections
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
 
 // Top Links
 $topLinks[] = [

diff --git a/app/templates/ProvisioningTargets/fields.inc b/app/templates/ProvisioningTargets/fields.inc
@@ -39,7 +39,7 @@ $fields = [
   'ordr'
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
 
 $subnav = [
   'name' => 'plugin',

diff --git a/app/templates/Servers/fields.inc b/app/templates/Servers/fields.inc
@@ -33,4 +33,4 @@ $fields = [
   ]
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
diff --git a/app/templates/element/clonable.php → app/templates/Standard/clonable.inc b/app/templates/element/clonable.php → app/templates/Standard/clonable.inc
@@ -25,12 +25,24 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-foreach(['uuid',
-         'cri',
-         'do_not_clone'] as $field) {
-  print $this->element('form/listItem', [
-    'arguments' => [
-      'fieldName' => $field
+return [
+  'clonable' => [
+    'fieldLabel' => __d('field','cloning'),
+    'labelIsTextOnly' => true, 
+    'groupedControls' =>  [
+      'uuid' => [
+        'singleRowItem' => true,
+        'label' => __d('field','uuid'),
+        'type' => 'text'
+      ],
+      'cri' => [
+        'singleRowItem' => true,
+        'label' => __d('field','cri')
+      ],
+      'do_not_clone' => [
+        'singleRowItem' => true,
+        'label' => __d('field','do_not_clone')
+      ]
     ]
-  ]);
-}
+  ]
+];
diff --git a/app/templates/Types/fields.inc b/app/templates/Types/fields.inc
@@ -36,7 +36,7 @@ $fields = [
   'edupersonaffiliation'
 ];
 
-print $this->element('clonable');
+$fields = array_merge($fields, include(ROOT . DS . 'templates' . DS . 'Standard/clonable.inc'));
 ?>
 
 <script>

diff --git a/app/templates/element/form/infoDiv/grouped.php b/app/templates/element/form/infoDiv/grouped.php
@@ -25,11 +25,9 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-
 declare(strict_types = 1);
 
-$classes = '';
-
+$blockClass = '';
 
 ?>
 
@@ -39,12 +37,12 @@
   $fieldArguments = $this->Field->restructureFieldArguments($fieldArguments);
 
   if(isset($fieldArguments['singleRowItem']) && $fieldArguments['singleRowItem']) {
-    $classes .= 'd-block ';
+    $blockClass = ' d-block';
     // This configuration is not needed for the control construction
     unset($fieldArguments['singleRowItem']);
   }
   ?>
-  <div class="subfield subfield-cols <?= $classes ?>">
+  <div class="subfield subfield-cols<?= $blockClass ?>">
     <div class="field-col">
     <?= $this->Field->formField($fieldName, ...$fieldArguments) ?>
     </div>

diff --git a/app/webroot/css/co-base.css b/app/webroot/css/co-base.css
@@ -1584,6 +1584,12 @@ ul.form-list .subfield-title {
 ul.form-list .subfield-cols {
   display: inline-flex;
 }
+ul.form-list .subfield-cols.d-block {
+  margin-top: 0.5rem;
+}
+ul.form-list .subfield-cols.d-block:first-child {
+  margin-top: 0;
+}
 ul.form-list .field-col .subfield-title {
   display: block;
   margin-bottom: 0;