Revert global search GET to POST (CFM-323) (#128)

COmanage · Oct 5, 2023 · 2c8a7d2 · 2c8a7d2
1 parent 74c452f
commit 2c8a7d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/app/src/Controller/DashboardsController.php b/app/src/Controller/DashboardsController.php
@@ -311,9 +311,9 @@ public function search() {
 
     // Gather our search string.
     $q = '';
-    if(!empty($this->request->getQuery('q'))) {
+    if(!empty($this->request->getData('q'))) {
       // A search was passed in from the form on the Global Search bar. 
-      $q = trim($this->request->getQuery('q'));
+      $q = trim($this->request->getData('q'));
     }
 
     // Only process the request if we have a string of non-space characters
@@ -398,7 +398,7 @@ public function search() {
 
       $this->Flash->information(__d('result',
                                     'search.exact',
-                                    [filter_var($this->request->getQuery('q'), FILTER_SANITIZE_SPECIAL_CHARS),
+                                    [filter_var($this->request->getData('q'), FILTER_SANITIZE_SPECIAL_CHARS),
                                      __d('controller', $matchClass, [1])]));
 
       // Redirect to the matchClass controller

diff --git a/app/templates/element/searchGlobal.php b/app/templates/element/searchGlobal.php
@@ -26,7 +26,7 @@
 */
 
 $options = [
-  'type' => 'get',
+  'type' => 'post',
   'url' => [
     'plugin'      => null,
     'controller'  => 'dashboards',
@@ -52,16 +52,15 @@
       ['class' => 'visually-hidden']
     );
     $globalSearchInputClass = 'global-search-query';
-    if(!empty($this->request->getQuery('q'))) {
+    if(!empty($this->request->getData('q'))) {
       $globalSearchInputClass .= ' has-value';
     }
     print $this->Form->input(
       'q',
       [
         'id' => 'q', 
         'class' => $globalSearchInputClass, 
-        'placeholder' => __d('field','search.placeholder'),
-        'value' => $this->request->getQuery('q')
+        'placeholder' => __d('field','search.placeholder')
       ]
     );
     print $this->Form->button(