Fix EmailVerifier rendering (CFM-333)

COmanage · Apr 13, 2025 · 60eedb6 · 60eedb6
1 parent 79e662d
commit 60eedb6
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 10 deletions.
diff --git a/app/plugins/CoreEnroller/src/Controller/EmailVerifiersController.php b/app/plugins/CoreEnroller/src/Controller/EmailVerifiersController.php
@@ -62,7 +62,10 @@ public function beforeRender(\Cake\Event\EventInterface $event) {
       $this->set('vv_bc_parent_primarykey', $this->EmailVerifiers->EnrollmentFlowSteps->getPrimaryKey());
     }
 
-    if ($this->getRequest()->getQuery("op") == "verify" || $this->getRequest()->getQuery("op") == "index") {
+    // We use the viewvar to determine the op since 'index' isn't always present
+    $op = $this->viewBuilder()->getVar('vv_op');
+
+    if($op == "verify" || $op == "index") {
       // This will suppress the default behavior. By default, we print the submit button in the
       // unorderedList.php element. But for the verify view we want to override and customize
       $this->set('suppress_submit', true);
@@ -80,9 +83,8 @@ public function beforeRender(\Cake\Event\EventInterface $event) {
    * @return void
    * @since COmanage Registry v5.1.0
    */
-  public function resend($id)
-  {
-
+
+  public function resend($id) {
     $this->viewBuilder()->setClassName('Json');
 
     if (!$this->getRequest()->is('ajax')) {

diff --git a/app/plugins/CoreEnroller/templates/element/emailVerifiers/list.php b/app/plugins/CoreEnroller/templates/element/emailVerifiers/list.php
@@ -57,8 +57,8 @@
     <th><?= __d('field', 'status') ?></th>
   </tr>
   </thead>
-  </tbody>
 
+  <tbody>
   <?php foreach(array_keys($vv_email_addresses) as $addr): ?>
   <?php
   $verified = isset($vv_verified_addresses[$addr]) && $vv_verified_addresses[$addr];
@@ -111,17 +111,16 @@
     <?php endif; ?>
     </td>
   </tr>
+  <?php endforeach; ?>
   </tbody>
 </table>
 
 <?php
-
 if($vv_minimum_met || count($vv_email_addresses) === 0) {
   $this->Field->enableFormEditMode();
 
   print $this->Form->hidden('op', ['default' => 'finish']);
 
   print $this->element('form/submit', ['label' => $vv_submit_button_label]);
 }
-?>
-<?php endforeach; ?>
+?>
diff --git a/app/plugins/CoreEnroller/templates/element/emailVerifiers/verify.php b/app/plugins/CoreEnroller/templates/element/emailVerifiers/verify.php
@@ -49,7 +49,7 @@
 print $this->element('form/listItem', [
   'arguments' => [
     'fieldName' => 'code',
-    'fieldLabel' => "Code", //__d('field', 'mail')
+    'fieldLabel' => __d('field', 'code'),
     'fieldOptions' => [
       'required' => true
     ]

diff --git a/app/resources/locales/en_US/field.po b/app/resources/locales/en_US/field.po
@@ -53,6 +53,9 @@ msgstr "Area Code"
 msgid "attribute"
 msgstr "Attribute"
 
+msgid "code"
+msgstr "Code"
+
 msgid "comment"
 msgstr "Comment"
 

diff --git a/app/templates/element/form/submit.php b/app/templates/element/form/submit.php
@@ -25,7 +25,6 @@
  * @license       Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
  */
 
-
 declare(strict_types = 1);
 ?>