Fix Primary Name error (CFM-494)

COmanage · Dec 18, 2025 · 7651e88 · 7651e88
1 parent f0b5328
commit 7651e88
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/app/resources/locales/en_US/field.po b/app/resources/locales/en_US/field.po
@@ -848,6 +848,9 @@ msgstr "Subject (Group)"
 msgid "Notifications.subject_person_id"
 msgstr "Subject (Person)"
 
+msgid "People.name.type_id"
+msgstr "Name Type"
+
 msgid "Petitions.enrollee_email"
 msgstr "Enrollee Email Address"
 

diff --git a/app/src/Model/Table/PeopleTable.php b/app/src/Model/Table/PeopleTable.php
@@ -407,7 +407,11 @@ public function findIndexed(Query $query): Query {
 
   public function generateDisplayField(Person $entity): string {
     if(empty($entity->primary_name)) {
-      throw new \InvalidArgumentException(__d('error', 'Names.primary_name'));
+      // Adding a new Person manually will generate an empty Person entity (with no Primary Name),
+      // which the Breadcrumbs logic (more specifically entityAndActionToTitle) will eventually
+      // pass here.
+
+      return __d('controller', 'People', [1]);
     }
 
     return $entity->primary_name->full_name;

diff --git a/app/templates/People/fields.inc b/app/templates/People/fields.inc
@@ -43,6 +43,7 @@ if($vv_action == 'add') {
 
   $fields['names.0.type_id'] = [
     'default' => $vv_default_name_type,
+    'fieldLabel' => __d('field', 'People.name.type_id'),
     'required' => true,
     'fieldType' => 'string'
   ];