Fix flash error construction.name type_id field is required

COmanage · Nov 15, 2024 · b444d89 · b444d89
1 parent 5ce3f4a
commit b444d89
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/app/src/Controller/StandardController.php b/app/src/Controller/StandardController.php
@@ -91,11 +91,17 @@ public function add() {
         $errors = $obj->getErrors();
 
         if(!empty($errors)) {
-          $this->Flash->error(__d('error', 'fields', [ implode(',', 
-                                                                 array_map(function($v) use ($errors) { 
-                                                                             return __d('error', 'flash', [$v, implode(',', array_values($errors[$v]))]);
-                                                                           },
-                                                                           array_keys($errors))) ]));
+          $errorlist = [];
+          foreach ($errors as $model => $fails) {
+            foreach ($fails as $issues) {
+              foreach ($issues as $column => $issue) {
+                $error_descriptions = array_values($issue);
+                $col_issues = implode(',', $error_descriptions);
+                $errorlist[] = __d('error', 'flash', [$column, $col_issues]);
+              }
+            }
+          }
+          $this->Flash->error(__d('error', 'fields', $errorlist));
         } else {
           $this->Flash->error(__d('error', 'save', [$modelsName]));
         }

diff --git a/app/templates/People/fields.inc b/app/templates/People/fields.inc
@@ -48,7 +48,8 @@ if($vv_action == 'add') {
     'arguments' => [
       'fieldName' => 'names.0.type_id',
       'fieldOptions' => [
-        'default' => $vv_default_name_type
+        'default' => $vv_default_name_type,
+        'required' => true
       ],
       'fieldType' => 'string'
     ]]);