Feature cfm150 autocomplete #167
Merged
+2,190
−425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
feature-cfm150-autocomplete
branch
4 times, most recently
from
505f226
to
365de7a
Compare
Ioannis
force-pushed
the
feature-cfm150-autocomplete
branch
from
99fab63
to
a18c993
Compare
…ual parsing and disambiguation (CFM-150)
…ndow; refactor setLayout to better accommodate multiple actions; carry over person picker code in preparation for moving the person picker ot the index of the Group Member list. (CFM-150)
…ch "Add" from the picker. (CFM-150)
Ioannis
commented
Mar 21, 2024
app/templates/element/menuAction.php
Outdated
| @@ -25,7 +25,7 @@ | |||
| * @license Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0) | |||
| */ | |||
|
|
|||
| $actionsCount = count($vv_actions); | |||
| $actionsCount = count($vv_actions) + (!empty($vv_people_picker) ? 1 : 0); | |||
There was a problem hiding this comment.
try this
count($vv_actions) + (int)!empty($vv_people_picker);
instead
There was a problem hiding this comment.
Great improvement - changed!
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.