CFM-291_Groups_Cous_extra_filtering_options #185
Merged
+933
−603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
commented
Apr 21, 2024
Ioannis
commented
- Add COUs any and none custom options.
- Move active filter button to its own element.
- Define extra custom filter Configuration structure for the default fields/columns.
…s own element. Define extra custom filter Configuration structure for the default fields/columns.
arlen
reviewed
Apr 22, 2024
| * @since COmanage Registry v5.0.0 | ||
| */ | ||
| public function getSearchFiltersExtras(): array | ||
| { |
There was a problem hiding this comment.
Trivially minor nit: we've not been following this curly brace convention (on its own line) anywhere else, so let's not start now. :-)
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.