Skip to content
Jump to bottom

CFM-291-refactor_form_code_structuring #187

Merged
merged 35 commits into from Apr 30, 2024
Merged

CFM-291-refactor_form_code_structuring #187

merged 35 commits into from Apr 30, 2024
+2,677 −1,529

Conversation

Ioannis
Copy link

@Ioannis Ioannis commented Apr 25, 2024

Decouple markup from FieldHelper.Move to elements.

@Ioannis Ioannis marked this pull request as draft April 25, 2024 16:22
@Ioannis Ioannis force-pushed the refactor_form_code_structuring branch from 6dcdeb0 to 1c6b6fb Compare April 25, 2024 16:26
@Ioannis Ioannis requested a review from arlen April 26, 2024 18:18
@Ioannis Ioannis marked this pull request as ready for review April 28, 2024 09:03
@Ioannis
Decouple markup from FieldHelper.Move to elements.
96758a1
@Ioannis
CoSettings
77205b7
@Ioannis
ApiUsers fields-generate.inc
ddeb738
@Ioannis
Cos
f03e0ad
@Ioannis
Addresses
56c5f05
@Ioannis
EmailAddresses
92a736e
@Ioannis
Groups
ea1d947
@Ioannis
Urls, Types, Servers
e722c77
@Ioannis
Identifiers,HistoryRecords,TelephoneNumbers,Names,AdHocAttributes,Per…
e8f5d67 
…sonRoles
@Ioannis
ExternalIdentities,ExternalIdentityRoles,ExternalIdentitySources
f47dd8d
@Ioannis
ExternalIdentitySourceRecords,IdentifierAssignments
b146ddc
@Ioannis
fixes
28a9aee
@Ioannis
update FieeldHelper
2d7c922
@Ioannis
Jobs
a2dac6b
@Ioannis
JobHistoryRecords
367b3da
@Ioannis
CoreAssigne, CoreServer
1808c07
@Ioannis
Pronouns,ProvisioningTargets,ProvisioningHistoryRecords
ab2f6a2
@Ioannis
ProvisioningHistoryRecords
5944be3
@Ioannis
People
16fe4c2
@Ioannis
Pipelines
6f87b15
@Ioannis
Jobs
28fd8c7
@Ioannis
GroupNestings
7f63b4b
@Ioannis
GroupMembers
8e73da0
@Ioannis
rename field parameters. Added prefix field.
3432946
@Ioannis
Available plugins.Alert to element.
75f4f88
@Ioannis
required field fix for nameDiv and infoDiv. Take fieldOptions into co…
53ca43d 
…nsideration.
@Ioannis Ioannis force-pushed the refactor_form_code_structuring branch from 1434f17 to 28d10be Compare April 29, 2024 14:37
@arlen
Copy link

arlen commented Apr 30, 2024

This is a huge improvement. From testing, two things need attention:

  1. Check the duplication of the 'Description' field and missing 'Provisioning Mode' on Provisioning Targets (starting at line 52 on templates/ProvisioningTargets/fields.inc), and

  2. Check on Generating an API Key: error: looks like there's an incorrect path to one of the new elements: [Cake\View\Exception\MissingElementException] Element file banner.php could not be found.

@arlen arlen merged commit e84d730 into COmanage:develop Apr 30, 2024
@Ioannis Ioannis deleted the refactor_form_code_structuring branch April 30, 2024 14:06
Sign in to join this conversation on GitHub.
Reviewers

@arlen arlen Awaiting requested review from arlen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ioannis @arlen