CFM-274_Breadcrumb_Component_External_Identity_Source_Record #207
+308
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
CFM-274_Breadcrumb_Component_External_Identity_Source_Record
branch
2 times, most recently
from
a4fa119
to
07e3767
Compare
benno
reviewed
Aug 30, 2024
| @@ -33,10 +33,24 @@ | |||
| use Cake\Log\Log; | |||
| use Cake\ORM\TableRegistry; | |||
|
|
|||
| class ExtIdentitySourceRecordsController extends StandardController { | |||
| class ExtIdentitySourceRecordsController extends MVEAController { | |||
There was a problem hiding this comment.
Why is ExtIdentitySourceRecord extending MVEAController? External Identity Source Records are not Multi-Valued Entity Attributes, and they have very different characteristics. If there's some function from MVEAController we want, we may need a different way to get it.
…inks to open on target _top
Ioannis
force-pushed
the
CFM-274_Breadcrumb_Component_External_Identity_Source_Record
branch
from
07e3767
to
aca14f7
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.