CFM-135_Model_Index_Filtering_Infrastructure #24
Merged
+520
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
CFM-135_Model_Index_Filtering_Infrastructure
branch
3 times, most recently
from
f3e5aad
to
28497db
Compare
Ioannis
force-pushed
the
CFM-135_Model_Index_Filtering_Infrastructure
branch
3 times, most recently
from
bfef1bc
to
7e8f100
Compare
|
See comments in slack re: date-range filtering. We may want a simple vs. advanced view of this if range filtering within the valid-from and valid-through is desired, but I suspect that in practice the user can get the same general behavior using only two fields (no interior ranges). Let's discuss. |
Ioannis
force-pushed
the
CFM-135_Model_Index_Filtering_Infrastructure
branch
from
1ebff21
to
e04e139
Compare
added 16 commits
May 16, 2022 08:14
Ioannis
force-pushed
the
CFM-135_Model_Index_Filtering_Infrastructure
branch
from
34436f0
to
2eaca37
Compare
arlen
approved these changes
May 19, 2022
| let dateWidgetInputs = document.querySelectorAll('duet-date-picker input'); | ||
| // Remove all the Vue related fields | ||
| Array.prototype.slice.call(dateWidgetInputs).forEach( (el) => { | ||
| el.parentNode.removeChild(el); |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit dynamic construct of Index filterin
g