CFM-105_Oauth2Server_MVC #310
Conversation
Ioannis
force-pushed
the
CFM-105_Oauth2Server_MVC
branch
from
033ac02
to
0659bac
Compare
Renane callback uri field to redirect uri Fetch access token
Ioannis
force-pushed
the
CFM-105_Oauth2Server_MVC
branch
from
0659bac
to
83f8473
Compare
| * @param array $context Validation context | ||
| * @return mixed True if $value validates, or an error string otherwise | ||
| */ | ||
| public function validateNotBlank(mixed $value, array $context): mixed |
There was a problem hiding this comment.
Instead of creating a new validation rule (it's not obvious from the name what the relation is to Cake's notEmptyString), can we update the validation definitions to use registerStringValidation?
eg, why can't we just do something like this:
$this->registerStringValidation($validator, $schema, 'scope', false);
There was a problem hiding this comment.
@benno, the method is an extraction of the following logic: validateNotBlank
// We require at least one non-whitespace character (CO-1551)
if (!preg_match('/\S/', $value)) {
return __d('error', 'input.blank');
}This is found in the custom validateInput function currently used in the COmanage v5 framework (built on CakePHP 4). That function also marks strings containing the characters <> as invalid. What if we only want to check for non-blank input—i.e., ensure there’s at least one non-whitespace character—without rejecting strings simply because they contain <>? Would using alone be more appropriate for this specific case? validateNotBlank
I cross referenced CAKEPHP2 implementation for this one.
No description provided.