Improve Relink UI and add People Picker (CFM-125)

app/resources/locales/en_US/field.po

@@ -1007,6 +1007,9 @@ msgstr "Last Status"
 msgid "ProvisioningTargets.status.live"
 msgstr "Live Status"
 
+msgid "target_person_id"
+msgstr "Target Person"
+
 msgid "TelephoneNumbers.formatted_number"
 msgstr "Telephone Number"
 

app/src/Controller/ExternalIdentitiesController.php

@@ -132,6 +132,7 @@ public function relink(string $id) {
     }
 
     // Fall through to the view to render a People Picker
+    $this->populateAutoViewVars(); // provides CO settings to the picker
 
     $this->set('vv_title', __d('operation', 'relink.a', [__d('controller', 'ExternalIdentities', [1])]));
 

app/src/Model/Table/ExternalIdentitiesTable.php

@@ -148,6 +148,16 @@ public function initialize(array $config): void {
         'type' => 'enum',
 // XXX maybe this (and EIRoles) should be SuspendableStatusEnum?
         'class' => 'StatusEnum'
+      ],
+      // Required for peoplePicker (for re-linking)
+      'cosettings' => [
+        'type' => 'auxiliary',
+        'model' => 'CoSettings'
+      ],
+      // Required for peoplePicker (for re-linking)
+      'types' => [
+        'type' => 'auxiliary',
+        'model' => 'Types'
       ]
     ]);
 

app/templates/ExternalIdentities/relink.php

@@ -43,9 +43,32 @@
   ]);
 
   print $this->Form->hidden('external_identity_id', ['default' => $vv_external_identity->id]);
-// This label isn't localized, but it should go away when the UX is fixed
-  print $this->Form->control('target_person_id', ['type' => 'integer', 'label' => 'Target Person ID']);
-
-  print $this->Form->submit();
+?>
+  <ul id="edit_ei-relink" class="fields form-list">
+<?php
+  $vv_autocomplete_arguments = [
+    'fieldName' => 'target_person_id',
+    'fieldLabel' => __d('field', 'target_person_id'),
+    'autocomplete' => [
+      'configuration' => [
+        'action' => 'GET',
+        'for' => 'co'
+      ]
+    ]
+  ];
+  print $this->element('form/listItem', ['arguments' => $vv_autocomplete_arguments]);
+
+?>
+    <li class="fields-submit">
+      <div class="field">
+        <div class="field-name">
+        </div>
+        <div class="field-info">
+          <?= $this->Form->submit() ?>              
+        </div>
+      </div>
+    </li>
+  </ul>
 
+<?php
   print $this->Form->end();

app/templates/element/form/listItem.php

@@ -29,7 +29,7 @@
 declare(strict_types = 1);
 
 // Make the element configuration available downstream
-// XXX Unfortunately CAKEPHP doe not create a viewvar space for the element
+// XXX Unfortunately CAKEPHP does not create a viewvar space for the element
 //     parameters. As a result we do not know which one is which unless we:
 //     - add a prefix and create a namespace
 //     - wrap them in an array.